Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roman Gushchin <guro@fb.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Linux MM <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@kernel.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v2 2/6] mm: kmem: cleanup memcg_kmem_uncharge_memcg()
 arguments
Thread-Topic: [PATCH v2 2/6] mm: kmem: cleanup memcg_kmem_uncharge_memcg()
 arguments
Thread-Index: AQHVxysvLmVWn6eilEKfaP/B4YhTxafknHcAgAQcoAA=
Date:   Mon, 13 Jan 2020 15:11:26 +0000
Message-ID: <20200113151122.GA22139@tower.DHCP.thefacebook.com>
References: <20200109202659.752357-1-guro@fb.com>
 <20200109202659.752357-3-guro@fb.com>
 <CALvZod59FA78-cgg1_T+qg6S-YW=VGu1Lj=j+uzWS9LzjAu1Xw@mail.gmail.com>
In-Reply-To: <CALvZod59FA78-cgg1_T+qg6S-YW=VGu1Lj=j+uzWS9LzjAu1Xw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c090:200::3:6ab2]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b1b71293-173a-4b98-ad1d-08d7983adc36
x-ms-traffictypediagnostic: BYAPR15MB2616:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR15MB2616DD987B93E7E31C6B1E20BE350@BYAPR15MB2616.namprd15.prod.outlook.com>
x-fb-source: Internal
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-forefront-prvs: 028166BF91
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(136003)(346002)(396003)(376002)(366004)(39860400002)(189003)(199004)(81166006)(5660300002)(66556008)(66476007)(64756008)(66446008)(66946007)(55016002)(4326008)(2906002)(9686003)(33656002)(6916009)(52116002)(53546011)(7696005)(81156014)(6506007)(16526019)(186003)(4744005)(478600001)(8676002)(316002)(54906003)(86362001)(1076003)(8936002)(71200400001);DIR:OUT;SFP:1102;SCL:1;SRVR:BYAPR15MB2616;H:BYAPR15MB2631.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gC6DLByeTEQaWqlpHSon7A/X0SyJ3eM49l+7fD3F1jevZmwdowEOif1K+acSJTdAJRrF2NXtzFNkFAxdeesXz8+NFscnz7TxVW3/Rl9GPddLLNOha+kNjza/YLGk9S7EVcDNenyBICt4fBk4yQFOhA964A98gry9Cngku7fcg4IqfnqeUoCmvWsiBfjTeBxJ3/YHn2Qqp1OuqdtKdsI3UKKDdgflc5EFQUeWzFXrOyW27+aCeekKpKSky907Sun5a8sYuVDEIrYFHlm6XDJ1/4kRg4NTohmVCJX/PobjOalLoJ7ViB4ippwG120hSqYtQNZGt9mzv1rrk2nDLORv2pMCvvgvYHfTvVJtD0SU+eZUDcrL7kc1KRGW5Q5BlY7Q4nngCYVYCZuB123ciIDfZDv/9CEMPWrlZ/sJXYyADLmpWwavbs0qhPaB0N1n9WxS
Content-Type: text/plain; charset="us-ascii"
Content-ID: <82884D7911372843AF18904B35C8AE4C@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: b1b71293-173a-4b98-ad1d-08d7983adc36
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2020 15:11:27.1777
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xcFaZPMOpYzVUmnm5QTlYE5skb4dBxzZLogDIjHpLuun9Vxslyq1ikr7+M267JWb
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2616
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-01-13_04:2020-01-13,2020-01-13 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0
 mlxlogscore=644 bulkscore=0 clxscore=1015 priorityscore=1501
 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0
 phishscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-1910280000
 definitions=main-2001130126
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 10, 2020 at 04:23:52PM -0800, Shakeel Butt wrote:
> On Thu, Jan 9, 2020 at 12:27 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > Drop the unused page argument and put the memcg pointer at the first
> > place. This make the function consistent with its peers:
> > __memcg_kmem_uncharge_memcg(), memcg_kmem_charge_memcg(), etc.
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
>=20
> Why not squash this patch in the previous one?

No particular reason, could be squashed too. Just made these changes one by=
 one.
Can be perfectly squashed, but probably it's not worth another version.

>=20
> Reviewed-by: Shakeel Butt <shakeelb@google.com>

Thank you for the review!