Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4063448ybl; Mon, 13 Jan 2020 07:15:46 -0800 (PST) X-Google-Smtp-Source: APXvYqyEbblgAqPlBnXGj3XHgX+EIYvU8t1Gt9QC1/Aviv4Sc525kHtUSsKjMWcNM8BJVNNPAxYZ X-Received: by 2002:aca:ba88:: with SMTP id k130mr13581656oif.167.1578928546588; Mon, 13 Jan 2020 07:15:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578928546; cv=none; d=google.com; s=arc-20160816; b=fvkQ9BWfcS3IL9v0ZbtKdHa0b8DGioz7HwIUwhVFITL/BEw7xmW7YSAlDWy5hT7UNR y44k3zGzF7l8shHm9sBHtWwPaoVoHhrK4bjFZnD5kl31f0Lfxr80SGxA0BMyH/lmYMak tGm6V7riLE5PqXQID29jBYeO279nT1CGSRDc/v/y1HOnBTGfCCkLLHpkDkAmmcfeeWiZ Z4IUp7ZB3VEi8r0V2PCTuWFvfABP4IH9jxfGaRg0mgcG0ehqCjBmtrVbTjkI1vQ4UXDO A4yCTKH/XuMNrjRxXsVvs7XhOdxzGSi7kegRdX2vfRwSHuAsY1Se9jvmkT9HuK1rnnQe GV+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=irz2Kk2MgarLlhAmA954LiHjpSSwxIvO/WqLw+4oQ1Y=; b=KeK7AhU2lC93F0uHXwICUpWGkbC8lbWYY0dPsmuJ/YTClvcmWJLgtuL82H9ysZYXiX /pZEx4rYcWXd8SVgqGVe/3qM8qr1SJXLDwGF7PMzwebNKMkQhqGeWqS6rEH3D7X5JrXW WDmaZsI9kt0wF+oDqlY0QwLmrYriknqVr4rBeP2PtJq3nLz6A2lPYhZL2k53vFmahuOB +3oDxTJvIR4htuPyv/m/C69PfT0gYeLR9UrNvEgi0tRCEO1kp1QGv2NGg5lzhMJMKQ6q hVXjc71QHOmsEMRMdyDeNSthT6SgPQuBkVaAJuZw2OECGlo4jWAd0se7LeEpwgci1Ye9 wTjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2hwwdBpU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si7211408otp.164.2020.01.13.07.15.34; Mon, 13 Jan 2020 07:15:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2hwwdBpU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729274AbgAMPNz (ORCPT + 99 others); Mon, 13 Jan 2020 10:13:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:39932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgAMPNy (ORCPT ); Mon, 13 Jan 2020 10:13:54 -0500 Received: from cakuba (unknown [172.58.35.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E949207E0; Mon, 13 Jan 2020 15:13:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578928434; bh=k37G7crg/rnM1OPMgaFjdTDn+Y4irTU6HvEVxVieUjM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2hwwdBpUxEHlF/MjAnrClMUvpSXE0hViNfyJbeItXwrJg/UYJfNs7k4g0NTGgL4qg oB47bgNla0FdArsPtX9RFkZtKktMmYBl6EAK5tKv6DMGQWLM3whpFWy2ndFngr58H1 e/SiSW/FESxRge2qm/qM6l5ZH530SABcPO51G5uQ= Date: Mon, 13 Jan 2020 07:12:51 -0800 From: Jakub Kicinski To: Jose Abreu Cc: netdev@vger.kernel.org, Joao Pinto , Giuseppe Cavallaro , Alexandre Torgue , "David S. Miller" , Maxime Coquelin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 2/8] net: stmmac: tc: Add support for ETF Scheduler using TBS Message-ID: <20200113071251.1d9d51f6@cakuba> In-Reply-To: <4a4290706a9166d67d2d455dfa9d5f259699a036.1578920366.git.Jose.Abreu@synopsys.com> References: <4a4290706a9166d67d2d455dfa9d5f259699a036.1578920366.git.Jose.Abreu@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jan 2020 14:02:37 +0100, Jose Abreu wrote: > +static int tc_setup_etf(struct stmmac_priv *priv, > + struct tc_etf_qopt_offload *qopt) > +{ > + There's a couple places I spotted where continuation lines are not aligned to the opening parenthesis, and here we have a spurious blank line. Please run this through checkpatch --strict, I see quite a few legit errors there.