Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7d49a8444ea1740444d1e9133104530731bfb30a.camel@archlinux.org>
Subject: Re: [PATCH] HID: logitech-hidpp: add support for the Powerplay
 mat/receiver
From:   Filipe =?ISO-8859-1?Q?La=EDns?= <lains@archlinux.org>
To:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
In-Reply-To: <20200112205021.3004703-1-lains@archlinux.org>
References: <20200112205021.3004703-1-lains@archlinux.org>
Organization: Archlinux
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-SqfsoRYx0FWj0PIgDlOr"
Date:   Mon, 13 Jan 2020 15:31:49 +0000
MIME-Version: 1.0
User-Agent: Evolution 3.34.3 
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-SqfsoRYx0FWj0PIgDlOr
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2020-01-12 at 20:50 +0000, Filipe La=C3=ADns wrote:
> I also marked all lightspeed devices as HID++ compatible. As the
> internal powerplay device does not have REPORT_TYPE_KEYBOARD or
> REPORT_TYPE_KEYBOARD it was not being marked as HID++ compatible in
> logi_hidpp_dev_conn_notif_equad.

Actually I had another look at the code and I don't understand why we
are manually setting |=3D HIDPP in
logi_hidpp_dev_conn_notif_equad/logi_hidpp_dev_conn_notif_27mhz. We
should set it in logi_dj_hidpp_event as it is triggered by receiving a
HID++ packet.

What do you think Benjamin?

--
Filipe La=C3=ADns

--=-SqfsoRYx0FWj0PIgDlOr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl4cjVoACgkQ+JPGdIFq
qV19XBAAh7RH19Z4xTovja5qdXkfK4GPahfaPvuXcFgD/B3HPUbugTHUVqqUkkDY
yJloDjloPk4Ug4jEO2p3fG+iZlWrM/sSoz8YDhpabMHuabV0ON2EDM0cxUY4o6iT
Hx/kQdxGm9OuU4ZwPgQUTUcWQqCzFY3QPFE7vBnlpF0vVgjYhlzFvlv+gqdvzVlf
1TlWyT+HYmz70w7Sk0Fo4ao2aDKbQbd+hMpwPXNVzsXE8sD2Kp3LjzycDwWp27vN
4TGod0hZQN8VDBS2VUd4X8jsdYERkXuVrQph8Hb7Xn5k1GuGhszkJXOz1ZY27aNX
PevlfCzs7aJfIKj5kBysdVJef0r/CwEASI+xzRS8+zLKoxvXKSIOWkke6n1FBxQm
py2x3j3PPiYL+3HGHDWMQP2MpYk9hTGb2GLo+VsiWZuqTffcH+xMCCXCgU2E05Jr
Y6w9HY9e5Alib5scgpJ52Lkt1GTx5xxnl7FP3LMjr9qf1lQNlFrUTimcgZ6vAJhL
OE3ND+iZQnz32/fAPQ1Jt8mSJEMzDyGS5gMwm0bXYfxRLE3A3c/FgtXo5IOG0dsG
19GDejciXw0f3nSL9O1yurcyYNKYp46l1JzdGUiX6yilI9uJZOpqcVDtzCmtPbEp
XCfqHGvPbE86eSkmbtnyQrmlCsyzc39KxKoFD1CzPdd9RJ5aZhM=
=vhH9
-----END PGP SIGNATURE-----

--=-SqfsoRYx0FWj0PIgDlOr--