Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] media: dvb_dummy_tuner: implement driver skeleton
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     mchehab@kernel.org, sean@mess.org, tglx@linutronix.de,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        skhan@linuxfoundation.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20200109233757.734008-1-dwlsalmeida@gmail.com>
 <20200110073024.GA156006@kroah.com>
From:   "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Message-ID: <d6d119cf-7447-31ce-37db-25503cf2f9bc@gmail.com>
Date:   Mon, 13 Jan 2020 15:23:02 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200110073024.GA156006@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greg,

I am working on v3. Would you mind clarifying this?


>> + *
>> + * The virtual DVB test driver serves as a reference DVB driver and helps
>> + * validate the existing APIs in the media subsystem. It can also aid developers
>> + * working on userspace applications.
>> + *
>> + * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
>> + * ISDB-T and ATSC when completed.
>> + *
>> + * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> Normally this is the first comment line above in this block.
>

Just so we're clear, do you mean this? e.g.:

+ * Copyright (c) 2020 Daniel W. S. Almeida <dwlsalmeida@gmail.com>
+ *
+ * The virtual DVB test driver serves as a reference DVB driver and helps
+ * validate the existing APIs in the media subsystem. It can also aid developers
+ * working on userspace applications.
+ *
+ * This dummy tuner should support common TV standards such as DVB-T/T2/S/S2,
+ * ISDB-T and ATSC when completed.
+ *


> Not the same license as your .c file?  Odd :(

Oops! :(


> If you keep this file, same comments as above for the comment block, but
> really, you don't need this .h file at all, just drop it.

OK.


- Daniel