Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200113181457.209ab4a5@canb.auug.org.au> <14674349-1864-2d10-1f09-55b1fb834475@zx2c4.com>
 <20200113192315.GS8904@ZenIV.linux.org.uk>
In-Reply-To: <20200113192315.GS8904@ZenIV.linux.org.uk>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Mon, 13 Jan 2020 14:33:31 -0500
Message-ID: <CAHmME9rBb5Otr-96W38kNjXkfok9NwFJ6V263qoPTJHqNEsgoA@mail.gmail.com>
Subject: Re: BUG_ON hit in "reimplement path_mountpoint() with less magic"
 [Was: Re: linux-next: Tree for Jan 13]
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hey Al,

On Mon, Jan 13, 2020 at 2:23 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Mon, Jan 13, 2020 at 01:27:34PM -0500, Jason A. Donenfeld wrote:
> > Hi Al,
> >
> > Your "reimplement path_mountpoint() with less magic" commit is causing
> > oopses on the linux-next tests running on https://build.wireguard.com/ .
> > Here's one such crash with debug symbols:
>
> Check if that persists with the version currently in #fixes (commit
> 7a955b7363b8).  It ought to be fixed there; quick check is to look
> at fs/namei.c:path_mountpoint() in your tree - it should read
>         if (!err && (nd->flags & LOOKUP_RCU))
>                 err = unlazy_walk(nd);
> not
>         if (!err)
>                 err = unlazy_walk(nd);
> as in the broken variant.

That does the trick. Glad that's sorted. Thanks.

Jason