Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Jan 2020 22:39:17 +0100
From:   Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= 
        <marmarek@invisiblethingslab.com>
To:     Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc:     xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
        Simon Gaiser <simon@invisiblethingslab.com>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        YueHaibing <yuehaibing@huawei.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] xen-pciback: optionally allow interrupt enable flag
 writes
Message-ID: <20200113213917.GD1314@mail-itl>
References: <20200111034347.5270-1-marmarek@invisiblethingslab.com>
 <9ea42829-6a1a-09eb-9d59-67a0487980b6@oracle.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6nSyB+bcl/pT7+kx"
Content-Disposition: inline
In-Reply-To: <9ea42829-6a1a-09eb-9d59-67a0487980b6@oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--6nSyB+bcl/pT7+kx
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH v3] xen-pciback: optionally allow interrupt enable flag
 writes

On Mon, Jan 13, 2020 at 04:25:02PM -0500, Boris Ostrovsky wrote:
>=20
>=20
> On 1/10/20 10:43 PM, Marek Marczykowski-G=C3=B3recki wrote:
> > @@ -117,6 +117,24 @@ static int command_write(struct pci_dev *dev, int =
offset, u16 value, void *data)
> >   		pci_clear_mwi(dev);
> >   	}
> > +	if (dev_data && dev_data->allow_interrupt_control) {
> > +		if ((cmd->val ^ val) & PCI_COMMAND_INTX_DISABLE) {
> > +			if (value & PCI_COMMAND_INTX_DISABLE) {
> > +				pci_intx(dev, 0);
> > +			} else {
> > +				/* Do not allow enabling INTx together with MSI or MSI-X. */
> > +				switch (xen_pcibk_get_interrupt_type(dev)) {
> > +				case INTERRUPT_TYPE_NONE:
> > +				case INTERRUPT_TYPE_INTX:
> > +					pci_intx(dev, 1);
>=20
> If INTERRUPT_TYPE_INTX , why call pci_intx(1)?

Not needed indeed.

>=20
> (I think I asked this last time as well).
>=20
>=20
> -boris
>=20
>=20

--=20
Best Regards,
Marek Marczykowski-G=C3=B3recki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

--6nSyB+bcl/pT7+kx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl4c44YACgkQ24/THMrX
1yz3pwf/X/M+UeKPbeYyYWubauScH6sB8Rm5cDdkP9ytWSdbqBJQnZHtKjta+gh2
yydiIOmPlVtcQeEgt+0ReyzL8bulfWPne3rRaZFFJPWxTy4KT4009UKEMAe2Rkl9
QbL8JjpmIJdzps5JacX7cYB3zn9h+p+CzgI9GUpyq9BM1JjHGWsNyIzgj6Vhcq4V
n80vE9lOkUqFknyj44HVAj0AfvQ/9cB0MxalKveZB5fpc5qe8jlQwlP/6EluoEya
W9LqR7KJdnK72nHi2O1Ch7YTLtaxT6anCHtzuvmef8pBhkaWjudnTd90MkEVWaDz
VTuvQx2FgNnJEcekPCHg8ve+5/0z/A==
=SAeV
-----END PGP SIGNATURE-----

--6nSyB+bcl/pT7+kx--