Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 13 Jan 2020 22:15:19 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Cc:     Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu/mpu6050: support dual-edge IRQ
Message-ID: <20200113221519.51557378@archlinux>
In-Reply-To: <20200111150735.GA16291@qmqm.qmqm.pl>
References: <MN2PR12MB33737F067F25B2F7477C4FE5C43C0@MN2PR12MB3373.namprd12.prod.outlook.com>
        <e5b39c16dc6dcb25324f6e8389cc0d0f895c1cbd.1578309319.git.mirq-linux@rere.qmqm.pl>
        <20200111121047.79e16365@archlinux>
        <20200111150735.GA16291@qmqm.qmqm.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 11 Jan 2020 16:07:35 +0100
Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl> wrote:

> On Sat, Jan 11, 2020 at 12:10:47PM +0000, Jonathan Cameron wrote:
> > On Mon, 06 Jan 2020 12:17:54 +0100
> > Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl> wrote:
> >  =20
> > > Make mpu6050 usable on platforms which provide only any-edge interrup=
ts.
> > > This also covers shared interrupt case. =20
> >=20
> > So this had me confused for a bit because I assumed we were trying to m=
ake
> > a level interrupt providing device work with edge interrupts.  Seems
> > device supports a pulsed  mode and the driver supports this.
> >=20
> > Why do we want to detect on both edges?  Do you have a crazy board
> > with this shared and some devices using the rising edge and some the fa=
lling one?
> >=20
> > For shared case it should return that it did not handle the interrupt
> > to allow spurious interrupt detection to work... =20
>=20
> Hmm. The shared interrupt is a red herring. I'll remove the sentence
> from commitmsg as it looks like the driver needs a few more fixups
> to be able to share the interrupt line.
>=20
> The patch is required on platforms that support only dual-edge
> interrupts, like eg. AT91SAM9G45-based one I have.

Yikes. That's a new one to me.  You have my sympathies.
Hmm. Normally I'd just call that a broken platform and ignore
it but I suppose this change isn't too harmful.

I'll aim to pick up v2, with the adjusted message.  If you haven't
done it yet, state the example platform as well.

Thanks,

Jonathan

>=20
> Best Regards,
> Micha=C5=82 Miros=C5=82aw