Date: Sun, 29 Jan 2006 17:47:26 -0600
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "Calin A. Culianu" <calin@ajvar.org>, linux-kernel@vger.kernel.org,
       akpm@osdl.org, Willy Tarreau <willy@w.ods.org>
Subject: Re: [PATCH] Watchdog: Winsystems EPX-C3 SBC
Message-ID: <20060129234726.GA20923@dmt.cnet>
References: <Pine.LNX.4.64.0601132149430.9231@rtlab.med.cornell.edu> <1137266649.23269.2.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1137266649.23269.2.camel@localhost.localdomain>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 655
Lines: 20

On Sat, Jan 14, 2006 at 07:24:09PM +0000, Alan Cox wrote:
> Some quick comments:
> 
> +       if (len) {
> +               epx_c3_pet();
> +       }
> 
> Doesn't need brackets (minor style)
> 
> Otherwise it looks excellent but should use request_region and friends
> to claim the two ports it uses.

It misses locking to protect against two concurrent writers in case of  
a shared /dev/wdt file-descriptor? 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/