Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4532796ybl; Mon, 13 Jan 2020 15:36:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxbSHagEFZu+AmsXKp2Ltqnsanocbwizujce7N6dmv1P/Z/7pTQa8h2yQubPOtwjTX8jRqx X-Received: by 2002:a05:6830:1bd5:: with SMTP id v21mr15789184ota.154.1578958591889; Mon, 13 Jan 2020 15:36:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578958591; cv=none; d=google.com; s=arc-20160816; b=nnkM6NQ20S6xl5KkEeUXu8ocT4hYwpNIRpBPfFnKnsZx7FIoBldzDY4+rjoAIiGqL4 pfJlP27T9gnJwx/0/3EJ/O4CTkWOI1zCn+3zqpDv+j/fIFVp/3kRkM6UGVerroafavlb 27Dr8nvx1lKcaq0pK+4ezP49DG6PrPIcCdnlZNuQWAFgOBcN7egok+JzLIQJFiiVzcWK EC0lTpkZFeZ8RTynus/ECBSuzID2yTKF6O2n1uGatWewlYkNTxMtrVvzJpbKkXvX9LGf MRUtrXr3L64aOmak1RxwG3zJyQdrrQDTfOQI5lpfVeHg53Z9wFaRwng3l/F5RYkzfHDZ ZrKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QwAoXOqjyyg/vJ5GZRN0tl9HB/BzOvUwdKHRpL6PwmI=; b=JecMFSeEW63lWcNg1xdZFVn/3lKEdxLL8e2CSee0kr1/kUHcX94kMt5eDFxyR/mYRG cCScaSv0FHCJv49kcR1GOBnPcAz0bNaaSUpg3rf7IBIQUwRFVT3A5Rurid8gwHo/jFlJ g2ESLMIQmYYmfqxRu180QzkhbwL5uK0DJO0JJRerDral2X3ONneFEFyFmwclC1PyYG52 DDs4PREqUnTW3A6IlR1xKiUu6OGPR6yUBgp/nE3BKmQr7Jrj+PG8unAK2ahxuFNyueUC w3OMdcnc/txlDgqd1vRFagT0GfsBn4983W0xy+W33id7JlpIb+iv4PqVx7ueEAjiFynm qZ9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=OvKpla9O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l14si7446648otk.225.2020.01.13.15.36.20; Mon, 13 Jan 2020 15:36:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=OvKpla9O; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729281AbgAMXaU (ORCPT + 99 others); Mon, 13 Jan 2020 18:30:20 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35538 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbgAMXaT (ORCPT ); Mon, 13 Jan 2020 18:30:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QwAoXOqjyyg/vJ5GZRN0tl9HB/BzOvUwdKHRpL6PwmI=; b=OvKpla9ORTpemj4RUAFr9Do/Ej d5IvnR79Rtu/GSeeBW7wb0+8Te29GyWtZruIrafjHVaz7flLIPYt/Z6Y9Yws0FHohEyeDONTTV/6q 9DEyMxjGCmEaRFB9inmS+f/SSN+37wW0i66XpBaMOSSqtrIwJVnXEan9IFrMDtzspMsw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ir99v-0008CN-Sw; Tue, 14 Jan 2020 00:30:11 +0100 Date: Tue, 14 Jan 2020 00:30:11 +0100 From: Andrew Lunn To: Horatiu Vultur Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, davem@davemloft.net, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, jakub.kicinski@netronome.com, vivien.didelot@gmail.com, olteanv@gmail.com, anirudh.venkataramanan@intel.com, dsahern@gmail.com, jiri@resnulli.us, ivecera@redhat.com, UNGLinuxDriver@microchip.com Subject: Re: [RFC net-next Patch v2 4/4] net: bridge: mrp: switchdev: Add HW offload Message-ID: <20200113233011.GF11788@lunn.ch> References: <20200113124620.18657-1-horatiu.vultur@microchip.com> <20200113124620.18657-5-horatiu.vultur@microchip.com> <20200113140053.GE11788@lunn.ch> <20200113225751.jkkio4rztyuff4xj@soft-dev3.microsemi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113225751.jkkio4rztyuff4xj@soft-dev3.microsemi.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Horatiu It has been said a few times what the basic state machine should be in user space. A pure software solution can use raw sockets to send and receive MRP_Test test frames. When considering hardware acceleration, the switchdev API you have proposed here seems quite simple. It should not be too hard to map it to a set of netlink messages from userspace. Yet your argument for kernel, not user space, is you are worried about the parameters which need to be passed to the hardware offload engine. In order to win the argument for a kernel solution, we are going to need a better idea what you think this problem is. The MRP_Test is TLV based. Are there other things which could be in this message? Is that what you are worried about? Thanks Andrew