Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200112205021.3004703-1-lains@archlinux.org> <7d49a8444ea1740444d1e9133104530731bfb30a.camel@archlinux.org>
 <CAO-hwJ+56qUTr8HQOLyx9tgbJMuTTPbb6K40cwWnO=PzMcO+tQ@mail.gmail.com> <1e4143394f773df60a2ba329c940b339e4563bee.camel@archlinux.org>
In-Reply-To: <1e4143394f773df60a2ba329c940b339e4563bee.camel@archlinux.org>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Tue, 14 Jan 2020 21:08:42 +1000
Message-ID: <CAO-hwJJ00Vy5Hv=gsbopr=8e8xJfmt7wvZf+CSVrSZZ=S0uO9Q@mail.gmail.com>
Subject: Re: [PATCH] HID: logitech-hidpp: add support for the Powerplay mat/receiver
To:     =?UTF-8?Q?Filipe_La=C3=ADns?= <lains@archlinux.org>
Cc:     Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 14, 2020 at 10:55 AM Filipe La=C3=ADns <lains@archlinux.org> wr=
ote:
>
> On Tue, 2020-01-14 at 20:48 +1000, Benjamin Tissoires wrote:
> > On Tue, Jan 14, 2020 at 1:31 AM Filipe La=C3=ADns <lains@archlinux.org>
> > wrote:
> > > On Sun, 2020-01-12 at 20:50 +0000, Filipe La=C3=ADns wrote:
> > > > I also marked all lightspeed devices as HID++ compatible. As the
> > > > internal powerplay device does not have REPORT_TYPE_KEYBOARD or
> > > > REPORT_TYPE_KEYBOARD it was not being marked as HID++ compatible
> > > > in
> > > > logi_hidpp_dev_conn_notif_equad.
> > >
> > > Actually I had another look at the code and I don't understand why
> > > we
> > > are manually setting |=3D HIDPP in
> > > logi_hidpp_dev_conn_notif_equad/logi_hidpp_dev_conn_notif_27mhz. We
> > > should set it in logi_dj_hidpp_event as it is triggered by
> > > receiving a
> > > HID++ packet.
> >
> > long story short: nope :)
> >
> > The whole purpose of setting the workitem->reports_supported is to be
> > able to create the matching report descriptor in the new virtual
> > device. So having this set in a callback will add an operation for
> > nothing every time we get an event, and will also not ensure a proper
> > separation of concerns.
> >
> > Cheers,
> > Benjamin
> >
> > > What do you think Benjamin?
> > >
> > > --
> > > Filipe La=C3=ADns
>
> Okay, then is maybe better if I add HIDPP to reports_supported based on
> the device ID (7). This is the only product to my knowledge that
> exports a device with ID 7. It's a better solution than setting HIDPP
> on all lightspeed devices.

Yep, looks better.

>
> I will send a new patch if you agree with this approach.

thanks.

Cheers,
Benjamin

>
> --
> Filipe La=C3=ADns