Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200113181457.209ab4a5@canb.auug.org.au> <eddaa93c-3bde-a9ed-5ee7-766f3cd51a43@infradead.org>
 <20200114104049.5244f612@canb.auug.org.au>
In-Reply-To: <20200114104049.5244f612@canb.auug.org.au>
From:   Brendan Higgins <brendanhiggins@google.com>
Date:   Mon, 13 Jan 2020 17:10:03 -0800
Message-ID: <CAFd5g454Xgb-tnG-rBQ3fkCe2bsO7M8_dauOTpG3bxDjnxOX9A@mail.gmail.com>
Subject: Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        KUnit Development <kunit-dev@googlegroups.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Alan Maguire <alan.maguire@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+KUnit Development
+open list:KERNEL SELFTEST FRAMEWORK

On Mon, Jan 13, 2020 at 3:40 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Randy,
>
> On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > on i386:
> >
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> > see include/linux/module.h for more information
>
> Sorry, I missed that yesterday.
>
> Caused by commit
>
>   c032ace71c29 ("software node: add basic tests for property entries")
>
> from the pm tree interacting with commit
>
>   9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
>
> from the kunit-next tree.

Yes, the problem seems to be that the property-entry-test is turned on
when CONFIG_KUNIT is y or m.

From drivers/base/test/Makefile:
...
obj-$(CONFIG_KUNIT) += property-entry-test.o

It seems we can fix it just by adding the missing MODULE_LICENSE, but
I think there is a bigger question of whether we should let people do
this. Do we want to just let people have their tests run whenever
CONFIG_KUNIT is enabled? I am inclined to think no. It should be
possible for people to run their test and their test only.