Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 4/8] i2c: tegra: Support atomic transfers
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Mikko Perttunen <cyndis@kapsi.fi>, linux-i2c@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200112171430.27219-1-digetx@gmail.com>
 <20200112171430.27219-5-digetx@gmail.com> <20200113220315.GB2689@ninjato>
 <86f71bfe-7d17-0bf4-edda-13c84301a598@gmail.com>
Message-ID: <49fbcb5d-011b-8ace-15f9-a36d4ae30397@gmail.com>
Date:   Tue, 14 Jan 2020 04:26:52 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <86f71bfe-7d17-0bf4-edda-13c84301a598@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

14.01.2020 01:52, Dmitry Osipenko пишет:
> 14.01.2020 01:03, Wolfram Sang пишет:
>> On Sun, Jan 12, 2020 at 08:14:26PM +0300, Dmitry Osipenko wrote:
>>> System shutdown may happen with interrupts being disabled and in this case
>>> I2C core rejects transfers if atomic transfer isn't supported by driver.
>>
>> Well, not quite. The core complains about it nowadays, but does not
>> reject messages. It will try the same behaviour as before. It will just
>> inform the user that somethings is tried which may not work. I probably
>> should update the error message printed saying that the transfer is
>> still tried.
> 
> Indeed, now I'm recalling noticing that the transfer actually should
> happen despite of the error message, but then completely forgot to
> update the commit's message. I can update the message and send out v5,
> if you're thinking that it's worthwhile to do.

I have time to do it now, will send v5 shortly.

And yes, clarifying the error message could be helpful. Although,
perhaps it won't help much to drivers which may schedule during the
atomic transfer.

>>> There were several occurrences where I found my Nexus 7 completely
>>> discharged despite of being turned off and then one day I spotted this in
>>> the log:
>>
>> Given my reasoning above, that should have happened before the warning
>> was printed as well? Because same behaviour. I'd be surprised if there
>> was a change...
> 
> Pretty sure that it was happening before, but I wasn't paying much
> attention back then.
>