Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4730979ybl; Mon, 13 Jan 2020 19:40:49 -0800 (PST) X-Google-Smtp-Source: APXvYqzyS0WMtD03PCwZIZavUVAkBh0lThbuIl4IDS/lf95ZU9lp87ACCMjlOZ68uqIld6NBeAY0 X-Received: by 2002:aca:b7c5:: with SMTP id h188mr15390939oif.100.1578973248973; Mon, 13 Jan 2020 19:40:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578973248; cv=none; d=google.com; s=arc-20160816; b=j606mr6b9JJBKAZStEg05HNEI5NM1ckruPVG+JPG4JN7FKDW93zltSn4fyKNMqwzX5 Vd5l5BWC7vlXndPgz1g3mwx2XpMGx+ytFTGDdYeL+0a4VwQEE49RBbK0Qmks45+F1PDc 7MWSUsxUwiWMsqLiftyd4bJmqYR9WbOyuET97tQdhIyVLruTjyBpsq0LVJq+zvggSuxI PoWa7+vQR5+JVLpyUGRtn+o9TKHapTc8/XG3eGvhWhW+hWL3ZQxKwdhE6bsHbc/BQ9wz /Cm/uSyoTOcCITHFvmMiLB/mlRJKua5h58yWOscanfr3q3ehcEypFbqqtxJQ9y/QTofe mkmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mkhc3ooO2qu2uQE34s1cJnl0CZJevJZbKaH3iSH14Yk=; b=ss+E+16/jvnl8UWL2qhWc7oiPxcmsw1ZIoCGjTnmnKjXvh8+p5sNSc9lpj/msKgFLG gnwKGKW8FL71AziBMd8F11WQDstO58Isr0uGNpkCx4pOxkJ4GYTqiEU+NRlhYT1R8qBC q2EaLPKbsqkBwY4iS/k0A8G1Ft2FxDgBbYGAgLklHJWbzygt0jr4tfspqQgy/8LA3Qqb tEq97yYIdT9yMVQc5j3EEgUhDf2c3kilYSFkdmdfDlBsjw+3qTFlsfxgKnjdljYVQE5n 541JJcR2AOA5xqK2jJH929EWrPAocWx8M/aeip+4RjoYHtWzHu5sBhDEsspHag2nGD1i JjnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h28si9361325otg.63.2020.01.13.19.40.35; Mon, 13 Jan 2020 19:40:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729539AbgANDE2 (ORCPT + 99 others); Mon, 13 Jan 2020 22:04:28 -0500 Received: from mga12.intel.com ([192.55.52.136]:31656 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729224AbgANDE2 (ORCPT ); Mon, 13 Jan 2020 22:04:28 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 19:04:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,431,1571727600"; d="scan'208";a="397354511" Received: from unknown (HELO chenyu-office) ([10.239.158.173]) by orsmga005.jf.intel.com with ESMTP; 13 Jan 2020 19:04:25 -0800 Date: Tue, 14 Jan 2020 11:04:00 +0800 From: Chen Yu To: "Rafael J. Wysocki" Cc: Linux PCI , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Linux PM , Linux Kernel Mailing List Subject: Re: [PATCH] PCI/PM: Print the pci config space of devices before suspend Message-ID: <20200114030400.GA5065@chenyu-office> References: <20200113060724.19571-1-yu.c.chen@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On Mon, Jan 13, 2020 at 11:01:28AM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 13, 2020 at 7:08 AM Chen Yu wrote: > > > > The pci config space was found to be insane during resume > > I wouldn't call it "insane". > > It probably means that the device was not present or not accessible > during hibernation and now it appears to be present (maybe the restore > kernel found it and configured it). > Right, thanks for the hint. If this is the case, it should not save any pci config settings if that device is not accessible, otherwise there's risk of pci config hard confliction after resumed. I've applied the patch and wait for the issue to be reproduced (not 100%) and will send the result later. Thanks, Chenyu