Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5020287ybl; Tue, 14 Jan 2020 02:06:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyr+HWgTMqJSeabDE2UolmwgGcnOSD1Ch+Lgl4LHibhg1DC8/UCMn9ewS+TY23h4dTR2Foa X-Received: by 2002:aca:3f54:: with SMTP id m81mr15158814oia.73.1578996366976; Tue, 14 Jan 2020 02:06:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578996366; cv=none; d=google.com; s=arc-20160816; b=aOOnUPSK8AdZNVFUSlqPnNRUrWAIdNHH0tnZCjK+Ojnp17QwyETWoi7Ocg8fMRkeTi w0OJSxiquSuTeFvl0qc/lyj+XECiETujl/04vPk8YH3i/M7cdq0w/A2NVNIEaGr0MJUU nXuzEbtVgkb11+vwtQZoMENWHHyD1tMcUxUCrNiM/vqYfCkv2KOkm2I0Cfjwuw4Gse4+ Ga6RGsQLBN2XaCXBYmT6p+F1juxywHRpyss5TbAS1Ante/VCnZ50fSBufc0rUc3OYqiA SKfpiOT7+yf+28/6lsOgS4mJSm7A+2Yt+ThCHbQO22S8zcBMakKDwsemF2VCfA8ZT7z9 fHAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u9SJHJ9lsQM0+NZN8FZJc6NFeMr6jQ8AH7TsYwYRHNQ=; b=zQlg+mgMAY8ewx6R2vJlpZA27kGRUSsfv/9OHBYiEeUFQVsBYL9YJ95YTwy0SYKlCA 7wnNV+Xl2yBXpX39BtRzl9gF41VEUaGF5bm3QO2T2aGfU6vEqqu2ySROgrpxhdWuXgAU hSyvugP8STogkis2kT06AuGaALcksDhwYf3JpgKYswvDUQBkhzPkj4JOdUSatDANs9wi c5NpinXq1ISdIbw687UU8jGYjbgPmoEr5ChIRSMPgG5Bz/W97tP0iv23i4PzSm/x0K90 cisQCUzNlrO70BI3YqVTse8lrgItByqeEZHWocJ0/aogtwG8bfnzXqVqhAvpV6fZd5I7 UMKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hYkyQhHd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y8si7264496oih.141.2020.01.14.02.05.55; Tue, 14 Jan 2020 02:06:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hYkyQhHd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729489AbgANKEc (ORCPT + 99 others); Tue, 14 Jan 2020 05:04:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:60164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729887AbgANKEa (ORCPT ); Tue, 14 Jan 2020 05:04:30 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F323224673; Tue, 14 Jan 2020 10:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996269; bh=UL/UGLYbiL1OR7mUNYU0zJhjbTK65irE5L1L83wy4zM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hYkyQhHdEGN6MiDQBRIwZbsVkjc8LrzI41FHfpBIFo7BC8GgQOb8ojUxQNYDAlQfR ZAZ6tj78SgaKO3711oi7PQ3ZnK0TQwghWfaAmv+b87LV2Qnxa0tJylkH7kncgKCBkC jNQHj1ZAZWkfdhENciQjUA01jsgdZJ1E/13nZ3UU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marcel Holtmann , Jiri Kosina Subject: [PATCH 5.4 18/78] HID: uhid: Fix returning EPOLLOUT from uhid_char_poll Date: Tue, 14 Jan 2020 11:00:52 +0100 Message-Id: <20200114094356.166466578@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094352.428808181@linuxfoundation.org> References: <20200114094352.428808181@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcel Holtmann commit be54e7461ffdc5809b67d2aeefc1ddc9a91470c7 upstream. Always return EPOLLOUT from uhid_char_poll to allow polling /dev/uhid for writable state. Fixes: 1f9dec1e0164 ("HID: uhid: allow poll()'ing on uhid devices") Signed-off-by: Marcel Holtmann Cc: stable@vger.kernel.org Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/uhid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/hid/uhid.c +++ b/drivers/hid/uhid.c @@ -772,7 +772,7 @@ static __poll_t uhid_char_poll(struct fi if (uhid->head != uhid->tail) return EPOLLIN | EPOLLRDNORM; - return 0; + return EPOLLOUT | EPOLLWRNORM; } static const struct file_operations uhid_fops = {