Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932144AbWA3JIM (ORCPT ); Mon, 30 Jan 2006 04:08:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932150AbWA3JIM (ORCPT ); Mon, 30 Jan 2006 04:08:12 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:2446 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S932144AbWA3JIL (ORCPT ); Mon, 30 Jan 2006 04:08:11 -0500 Date: Mon, 30 Jan 2006 10:07:57 +0100 (MET) From: Jan Engelhardt To: Andrew Morton cc: Olaf Dietsche , eike-kernel@sf-tec.de, Linux Kernel Mailing List Subject: Re: [PATCH 2.6.16-rc1-git4] accessfs: a permission managing filesystem In-Reply-To: <20060128150137.5ba5af04.akpm@osdl.org> Message-ID: References: <87ek3a8qpy.fsf@goat.bogus.local> <200601231257.28796@bilbo.math.uni-mannheim.de> <87mzhgyomh.fsf@goat.bogus.local> <20060128150137.5ba5af04.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 432 Lines: 17 >> +static DECLARE_MUTEX(accessfs_sem); > >Please use a `struct mutex'. You know what's irritating? That DECLARE_MUTEX starts a semaphore and DEFINE_MUTEX a mutex. Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/