Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5024475ybl; Tue, 14 Jan 2020 02:10:15 -0800 (PST) X-Google-Smtp-Source: APXvYqxQHk+tD+SNYBbXCWXbNGqc8thRnZc/Mf8wexuufi1buTVIadj9Rml121VPD4Eru9c9sx+i X-Received: by 2002:a9d:708f:: with SMTP id l15mr17289033otj.229.1578996615064; Tue, 14 Jan 2020 02:10:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578996615; cv=none; d=google.com; s=arc-20160816; b=D+cCE4uxEkrfL8VtGEB2BZKN1OkcjME3WcMiNvmGexQcSWkKHlc0s8aLiJ87UW0plh qe5fo9aqxc9gi6nkMCc8y79jHWdzYgKuPHPu1JPLXxBjhwXdH2gPXhx8yaY750Yf/WlG DpeWZEuowVtwvMOYKRHvrDU3zCpCMOtTTpBjO0fTu9OcvmoI6hmFnwO7l17ULlj9RvBG DsjAi75qAEU6OTNqrpf3pk7Lkrh2dYIjhiAMgKpK4rmSjpkZENCtnud2442uSc2wqZOH BIX2SXTaj4TFn8G95MtS1MmxWXWJv65iYNaLK6LGJQICsgn6bZgHgmL0xpaOFCrTXb2S mfDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HRnsuoQxMghvBcWQMyOoPEdAlUezesd7utFLXmPxG8A=; b=wqzXOVnEWBTPIW6vbi4FWqOHPKUz6aRNon4K/2L9n1uvuUX4CBQsVnQU1SiejuMti0 nI36pzEY9DSgmCXxMXuzkVuj7uQMvwKj17TDDypAf/escpLE+zyz+ykoweaQUQS41keX 81g6phS2xuLaxvtgFXa+Mpimk2twETW6IA97ZoV6xikPZH1ZJhWGC7iHvVwcs1WiRO1n PEVM8mmeNVODUnXLl9sDaWzrrues8dkvXvQ8K1C+MTvobsIouHlczjEy5EDTft17pdON Q5YE/1eBVGe1wIHU+SIvDz01tvDx28/Q5pDKKyI458w/Gb1RKyUBCTWYhRV/Otr9bPSC 7zNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Zi9t3OEn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si8526688otr.88.2020.01.14.02.10.04; Tue, 14 Jan 2020 02:10:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Zi9t3OEn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731184AbgANKJB (ORCPT + 99 others); Tue, 14 Jan 2020 05:09:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:41076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731176AbgANKI7 (ORCPT ); Tue, 14 Jan 2020 05:08:59 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9622124679; Tue, 14 Jan 2020 10:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578996539; bh=IAWoV7sLHY7VarPJfk6cJJN8sA4BpJYPO9/iJ9t548g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zi9t3OEnrUgRZwzkf6NpJkQ6RsSL/guWjQHwRE+KCtvANxpux+GtSdkF7NBpVg65k ad7LxaRjcQyHDhrosuim0BF9slVXIP304GGMmK3kGF1sZ28hwYTX1yceRv5P/cLXqP zGEcfSzt4RP/eVGbroU39Wna0+pBjKBlGidjKmBE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Kalle Valo , Ben Hutchings Subject: [PATCH 4.19 39/46] ath10k: fix memory leak Date: Tue, 14 Jan 2020 11:01:56 +0100 Message-Id: <20200114094347.933299495@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114094339.608068818@linuxfoundation.org> References: <20200114094339.608068818@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit b8d17e7d93d2beb89e4f34c59996376b8b544792 upstream. In ath10k_usb_hif_tx_sg the allocated urb should be released if usb_submit_urb fails. Signed-off-by: Navid Emamdoost Signed-off-by: Kalle Valo Cc: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/ath/ath10k/usb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/wireless/ath/ath10k/usb.c +++ b/drivers/net/wireless/ath/ath10k/usb.c @@ -454,6 +454,7 @@ static int ath10k_usb_hif_tx_sg(struct a ath10k_dbg(ar, ATH10K_DBG_USB_BULK, "usb bulk transmit failed: %d\n", ret); usb_unanchor_urb(urb); + usb_free_urb(urb); ret = -EINVAL; goto err_free_urb_to_pipe; }