Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932156AbWA3JRE (ORCPT ); Mon, 30 Jan 2006 04:17:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932157AbWA3JRE (ORCPT ); Mon, 30 Jan 2006 04:17:04 -0500 Received: from smtp.osdl.org ([65.172.181.4]:64159 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932156AbWA3JRB (ORCPT ); Mon, 30 Jan 2006 04:17:01 -0500 Date: Mon, 30 Jan 2006 01:16:30 -0800 From: Andrew Morton To: Jan Engelhardt Cc: olaf+list.linux-kernel@olafdietsche.de, eike-kernel@sf-tec.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.16-rc1-git4] accessfs: a permission managing filesystem Message-Id: <20060130011630.60f402d8.akpm@osdl.org> In-Reply-To: References: <87ek3a8qpy.fsf@goat.bogus.local> <200601231257.28796@bilbo.math.uni-mannheim.de> <87mzhgyomh.fsf@goat.bogus.local> <20060128150137.5ba5af04.akpm@osdl.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 506 Lines: 17 Jan Engelhardt wrote: > > > >> +static DECLARE_MUTEX(accessfs_sem); > > > >Please use a `struct mutex'. > > You know what's irritating? That DECLARE_MUTEX starts a semaphore and > DEFINE_MUTEX a mutex. > DECLARE_MUTEX will go away. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/