Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932162AbWA3J3s (ORCPT ); Mon, 30 Jan 2006 04:29:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932165AbWA3J3s (ORCPT ); Mon, 30 Jan 2006 04:29:48 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:8333 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S932162AbWA3J3r (ORCPT ); Mon, 30 Jan 2006 04:29:47 -0500 Date: Mon, 30 Jan 2006 10:29:40 +0100 (MET) From: Jan Engelhardt To: "Eric W. Biederman" cc: Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] pid: Don't hash pid 0. In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 445 Lines: 20 >@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en > { > struct pid *pid, *task_pid; > >+ if (!nr) >+ goto out; >+ How about nr==0, it would make it more obvious. Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/