Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbWA3Jcm (ORCPT ); Mon, 30 Jan 2006 04:32:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932167AbWA3Jcm (ORCPT ); Mon, 30 Jan 2006 04:32:42 -0500 Received: from smtp.osdl.org ([65.172.181.4]:33955 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S932158AbWA3Jcl (ORCPT ); Mon, 30 Jan 2006 04:32:41 -0500 Date: Mon, 30 Jan 2006 01:32:14 -0800 From: Andrew Morton To: Jan Engelhardt Cc: olaf+list.linux-kernel@olafdietsche.de, eike-kernel@sf-tec.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.16-rc1-git4] accessfs: a permission managing filesystem Message-Id: <20060130013214.0da54582.akpm@osdl.org> In-Reply-To: References: <87ek3a8qpy.fsf@goat.bogus.local> <200601231257.28796@bilbo.math.uni-mannheim.de> <87mzhgyomh.fsf@goat.bogus.local> <20060128150137.5ba5af04.akpm@osdl.org> <20060130011630.60f402d8.akpm@osdl.org> X-Mailer: Sylpheed version 1.0.4 (GTK+ 1.2.10; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 596 Lines: 20 Jan Engelhardt wrote: > > >> >> +static DECLARE_MUTEX(accessfs_sem); > >> > > >> >Please use a `struct mutex'. > >> > >> You know what's irritating? That DECLARE_MUTEX starts a semaphore and > >> DEFINE_MUTEX a mutex. > > > >DECLARE_MUTEX will go away. > > And be replaced by... DEFINE_SEMAPHORE? > That would be logical. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/