Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932171AbWA3Jos (ORCPT ); Mon, 30 Jan 2006 04:44:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932172AbWA3Jos (ORCPT ); Mon, 30 Jan 2006 04:44:48 -0500 Received: from smtpout06-01.prod.mesa1.secureserver.net ([64.202.165.224]:8654 "HELO smtpout06-04.prod.mesa1.secureserver.net") by vger.kernel.org with SMTP id S932171AbWA3Jor (ORCPT ); Mon, 30 Jan 2006 04:44:47 -0500 Message-ID: <43DDE009.9090104@sairyx.org> Date: Mon, 30 Jan 2006 20:44:41 +1100 From: Yuki Cuss User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051013) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jan Engelhardt CC: "Eric W. Biederman" , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] pid: Don't hash pid 0. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 675 Lines: 30 Jan Engelhardt wrote: >>@@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en >>{ >> struct pid *pid, *task_pid; >> >>+ if (!nr) >>+ goto out; >>+ >> >> > >How about nr==0, it would make it more obvious. > > > >Jan Engelhardt > > I am inclined to agree. `!nr' seems to imply some sort of an error condition; perhaps a comment could be placed in order to make why the case of (nr == 0) is being ignored. - Yuki. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/