Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932173AbWA3Jql (ORCPT ); Mon, 30 Jan 2006 04:46:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932174AbWA3Jql (ORCPT ); Mon, 30 Jan 2006 04:46:41 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:10649 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S932173AbWA3Jqk (ORCPT ); Mon, 30 Jan 2006 04:46:40 -0500 Subject: Re: [PATCH 2.6.16-rc1-git4] accessfs: a permission managing filesystem From: Arjan van de Ven To: Jan Engelhardt Cc: Andrew Morton , olaf+list.linux-kernel@olafdietsche.de, eike-kernel@sf-tec.de, linux-kernel@vger.kernel.org In-Reply-To: References: <87ek3a8qpy.fsf@goat.bogus.local> <200601231257.28796@bilbo.math.uni-mannheim.de> <87mzhgyomh.fsf@goat.bogus.local> <20060128150137.5ba5af04.akpm@osdl.org> <20060130011630.60f402d8.akpm@osdl.org> Content-Type: text/plain Date: Mon, 30 Jan 2006 10:46:27 +0100 Message-Id: <1138614388.2977.10.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 21 On Mon, 2006-01-30 at 10:24 +0100, Jan Engelhardt wrote: > >> >> +static DECLARE_MUTEX(accessfs_sem); > >> > > >> >Please use a `struct mutex'. > >> > >> You know what's irritating? That DECLARE_MUTEX starts a semaphore and > >> DEFINE_MUTEX a mutex. > > > >DECLARE_MUTEX will go away. > > And be replaced by... DEFINE_SEMAPHORE? ... or just go away entirely, depending if there are any users of it left after all mutexes have been converted to DEFINE_MUTEX()... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/