Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932180AbWA3Jtb (ORCPT ); Mon, 30 Jan 2006 04:49:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932182AbWA3Jtb (ORCPT ); Mon, 30 Jan 2006 04:49:31 -0500 Received: from linux01.gwdg.de ([134.76.13.21]:63167 "EHLO linux01.gwdg.de") by vger.kernel.org with ESMTP id S932180AbWA3Jta (ORCPT ); Mon, 30 Jan 2006 04:49:30 -0500 Date: Mon, 30 Jan 2006 10:49:18 +0100 (MET) From: Jan Engelhardt To: Yuki Cuss cc: "Eric W. Biederman" , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH] pid: Don't hash pid 0. In-Reply-To: <43DDE009.9090104@sairyx.org> Message-ID: References: <43DDE009.9090104@sairyx.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 22 >> How about nr==0, it would make it more obvious. > > I am inclined to agree. `!nr' seems to imply some sort of an error condition; ! seems to imply a boolean usually. (If this was Java, this would even be enforced.) However, !x (and x) is scattered all around the kernel where x==0,x!=0 (or x==NULL,x!=NULL) would be more readable. > perhaps a comment could be placed in order to make why the case of (nr == 0) is > being ignored. > > - Yuki. > Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/