From: Andi Kleen <ak@suse.de>
To: Muli Ben-Yehuda <mulix@mulix.org>
Subject: Re: [PATCH RESEND] move swiotlb.h header file to asm-generic
Date: Mon, 30 Jan 2006 10:49:41 +0100
User-Agent: KMail/1.8.2
Cc: Andrew Morton <akpm@osdl.org>, Jon Mason <jdmason@us.ibm.com>,
       Christoph Hellwig <hch@lst.de>, "Luck, Tony" <tony.luck@intel.com>,
       Linux-Kernel <linux-kernel@vger.kernel.org>,
       Muli Ben-Yehuda <MULI@il.ibm.com>
References: <20060130094434.GG23968@granada.merseine.nu>
In-Reply-To: <20060130094434.GG23968@granada.merseine.nu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200601301049.41854.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 835
Lines: 22

On Monday 30 January 2006 10:44, Muli Ben-Yehuda wrote:
> This patch:
> 
> - creates asm-generic/swiotlb.h
> - makes it use 'enum dma_data_direction dir' rather than 'int dir'
> - updates x86-64 and IA64 to use the common swiotlb.h
> - fixes the resulting fall out (s/int dir/enum dma_data_direction dir/
>   all over the place).

Al Viro will likely flame you badly for that enum change. Apparently it 
causes some trouble in sparse. Frankly i don't see the point neither.
It just makes the code harder to read and creates a monstrosity of a patch 
and doesn't give you anything.

-Andi

>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/