Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 14 Jan 2020 12:33:24 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Saravanan Sekar <sravanhome@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Maxime Ripard <mripard@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        "heiko@sntech.de" <heiko@sntech.de>,
        Sam Ravnborg <sam@ravnborg.org>,
        Icenowy Zheng <icenowy@aosc.io>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        David Miller <davem@davemloft.net>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 2/4] dt-bindings: regulator: add document bindings for
 mpq7920
Message-ID: <20200114123324.GS3897@sirena.org.uk>
References: <20200109112548.23914-1-sravanhome@gmail.com>
 <20200109112548.23914-3-sravanhome@gmail.com>
 <CAL_JsqJ4vTzyfAG2UWzzkhVkBSLDRPjdyDUFZJ9LrDmsFsQ1gA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="foM9DbudB2CcldhH"
Content-Disposition: inline
In-Reply-To: <CAL_JsqJ4vTzyfAG2UWzzkhVkBSLDRPjdyDUFZJ9LrDmsFsQ1gA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--foM9DbudB2CcldhH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 13, 2020 at 10:56:55AM -0600, Rob Herring wrote:
> On Thu, Jan 9, 2020 at 5:26 AM Saravanan Sekar <sravanhome@gmail.com> wrote:

> > Add device tree binding information for mpq7920 regulator driver.
> > Example bindings for mpq7920 are added.

> Mark, Please revert this. Not even close to valid schema and my
> questions on v4 are unanswered.

OK...  I didn't see any comments on V5.

> > +      mps,switch-freq:

> As I asked on v4, shouldn't this be a common property? Switching
> frequency is a common property for switching regulators, right?

It's not very common and where it's offered the valid values are
generally highly constrained so I'm not sure it makes sense to do
that, any device that does have this feature will want to specify
the valid values for that particular device.

--foM9DbudB2CcldhH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4dtRMACgkQJNaLcl1U
h9CAuAf/bAfTT3rYtCh0iL5pJ5AemEgO/3RbG+Zke1dFVUaYwpEDpyfsxSysbSqm
LIc4dsM+NPfiQ7LxzMfXNfzydbdj+1Ts+pVnlnJkbE7daQvZY008yEQghcswTD3M
9qZWmJNCHZtH0knhDN2Zekoei9nWqHvLoYAC/X24QT/okiNFTRjIepKKYLobx3mm
RkdwNumjL86O9EuYVgznLyFfr0BvmvqagpDhBV5KHdBQNUgHvr0JjQAKoVUR4N+A
qoJSp3OTaBtLvHGUv1BhqLbITn4eRLlP3uKw+H5EgmMQKW75U6dGwmh6a+nswI7E
Xp7ZiwxEKfBN252W1sexbJOmhkm+7A==
=qm5x
-----END PGP SIGNATURE-----

--foM9DbudB2CcldhH--