Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
From:   Axel Lin <axel.lin@ingics.com>
Date:   Tue, 14 Jan 2020 20:49:16 +0800
Message-ID: <CAFRkauBRi2g_4b3wUnmwLkeogTyWjX4=6VfyDLJr-REf=LeC-w@mail.gmail.com>
Subject: regulator: mpq7920: Some inconsistencies in current driver
To:     Saravanan Sekar <sravanhome@gmail.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Saravanan,

There are a few inconsistencies in current driver:
I don't have the datasheet, so I'm not 100% sure.
Maybe you can help check it.

1. It's unlikely MPQ7920_LDO1_REG_B and MPQ7920_REG_CTL0 have the same address.
   I think this needs double check.

2. The MPQ7920_DISCHARGE_ON seems wrong because it does not match
MPQ7920_MASK_DISCHARGE.
   I guess MPQ7920_DISCHARGE_ON should be BIT(5).

3. The MPQ7920_MASK_BUCK_ILIM seems wrong. I guess it should be 0xC0.

4. Not sure why define both MPQ7920_REG_REGULATOR_EN1 and
MPQ7920_REG_REGULATOR_EN.

Regards,
Axel