Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5322110ybl; Tue, 14 Jan 2020 07:07:13 -0800 (PST) X-Google-Smtp-Source: APXvYqwZLL82/93AuPzPsdPizBpK4dNpTjyzA6NIA1sbEEeryQ7nJ38O1jgli1161bIVFFHsRTP1 X-Received: by 2002:aca:3542:: with SMTP id c63mr17432697oia.135.1579014432888; Tue, 14 Jan 2020 07:07:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579014432; cv=none; d=google.com; s=arc-20160816; b=AM5Cw3QqHaQX5e+Yjzib8le04SUA6OnxoxLf2T8Zs1gT69bbebTVanySGDIUI1ZPe3 fOkjCVA8fj7ETA2QjHLgI8bFck5a6MPysaJef/79ZtQOX9YsC22Wj0ghbmUT+C/qkxrX 9hx8ei+Qvvop83JWjYSuaOifaEDvr+T9UpSm0X6gUIVgdnyJz+SA/pi7HwqeDFgxCkub oztSEwjgFFkK5KoxXCcG10OX9DjhqORURcQjGkxYyfyvhFFU6yyjKHZzTWWAruf3hACF XtfF9RgDsRUgMP0ClXkT+meGWXt694BVO85pyIfUbwVrAguWPy9Sn/luQwa5iB/bQpO/ a63g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=E65x8pSr8W78K+nkv+oRyhXIgspfcdDqAN6DLuiHZ3E=; b=CG21tFHunV+zGFHTUYcvlExBcsHr3arZ6I3M35mlU/yuCB6QHpVcYIfi6pGOR0wVUm nNN2OECFVVPh+bZgk0IH0g3wG0WQ6LO2bGEKn0kK6WJMWx3F6j5WydY6oTnDaT0MTOM8 EzMF95XHKKkwFC1jLtSF7WoaD0/5VerAKPY1X/YzO6GgJ+4VGQnB4BZUhpEug8f39Gzm z+WClZue4szW01ZDsUJQf+NthbKpQ87xE9j9cN+MNCKwAVBsxa4gynCa60gjtqi7Htwx lBbmHAh8G2YB6hrmfmrgKF+drfb8aycruLo4ruwLiYm8ADKWsErqfFlHuLORQPYZtXZ6 2YcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HkmdOP22; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s68si8265680oih.275.2020.01.14.07.06.56; Tue, 14 Jan 2020 07:07:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HkmdOP22; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729138AbgANPFd (ORCPT + 99 others); Tue, 14 Jan 2020 10:05:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:47242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbgANPFd (ORCPT ); Tue, 14 Jan 2020 10:05:33 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 537E3222C4; Tue, 14 Jan 2020 15:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579014332; bh=ydeBuosiltPcfsDEdZvc5kVp7iD71bPEmNOTm05qYEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HkmdOP22cGskIQMD2YCPEllQ3MCdzu/35gtVL61fkqXuQE8lsI4X0vA0APRGqN9ET ATbjZ+sON3udGwGI5lSEAqy3ZwHExS0sK9NJ6FF2rvFBNWPv5hj0MP1Y9qrE7UR75Q WQLntYYqzHvl3hnUNtLzfRT0pYjZDpIMPXD9Qrtw= Date: Tue, 14 Jan 2020 16:05:30 +0100 From: Greg KH To: Gabriel Krisman Bertazi Cc: rafael@kernel.org, lduncan@suse.com, cleech@redhat.com, jejb@linux.ibm.com, martin.petersen@oracle.com, open-iscsi@googlegroups.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 1/3] drivers: base: Support atomic version of attribute_container_device_trigger Message-ID: <20200114150530.GA1975425@kroah.com> References: <20200106185817.640331-1-krisman@collabora.com> <20200106185817.640331-2-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200106185817.640331-2-krisman@collabora.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2020 at 01:58:15PM -0500, Gabriel Krisman Bertazi wrote: > attribute_container_device_trigger invokes callbacks that may fail for > one or more classdev's, for instance, the transport_add_class_device > callback, called during transport creation, does memory allocation. > This information, though, is not propagated to upper layers, and any > driver using the attribute_container_device_trigger API will not know > whether any, some, or all callbacks succeeded. > > This patch implements a safe version of this dispatcher, to either > succeed all the callbacks or revert to the original state. > > Signed-off-by: Gabriel Krisman Bertazi Reviewed-by: Greg Kroah-Hartman