Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 14 Jan 2020 16:28:06 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     John Garry <john.garry@huawei.com>
Cc:     James Bottomley <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        Linuxarm <linuxarm@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "saravanak@google.com" <saravanak@google.com>,
        Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v1] driver core: Use list_del_init to replace list_del at
 device_links_purge()
Message-ID: <20200114152806.GA2043229@kroah.com>
References: <20200108122658.GA2365903@kroah.com>
 <73252c08-ac46-5d0d-23ec-16c209bd9b9a@huawei.com>
 <1578498695.3260.5.camel@linux.ibm.com>
 <20200108155700.GA2459586@kroah.com>
 <1578499287.3260.7.camel@linux.ibm.com>
 <4b185c9f-7fa2-349d-9f72-3c787ac30377@huawei.com>
 <3826a83d-a220-2f7d-59f6-efe8a4b995d7@huawei.com>
 <1578531860.3852.7.camel@linux.ibm.com>
 <20200114150739.GA1975985@kroah.com>
 <6820e1c4-07ab-0748-0bf3-e1c25c524a40@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6820e1c4-07ab-0748-0bf3-e1c25c524a40@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 14, 2020 at 03:20:12PM +0000, John Garry wrote:
> On 14/01/2020 15:07, Greg KH wrote:
> > On Wed, Jan 08, 2020 at 05:04:20PM -0800, James Bottomley wrote:
> > > On Wed, 2020-01-08 at 17:10 +0000, John Garry wrote:
> > > > On 08/01/2020 16:08, John Garry wrote:
> > > > > On 08/01/2020 16:01, James Bottomley wrote:
> > > > > > > > >      cdev->dev = NULL;
> > > > > > > > >              return device_add(&cdev->cdev);
> > > > > > > > >          }
> > > > > > > > >      }
> > > > > > > > >      return -ENODEV;
> > > > > > > > > }
> > > > > > > > 
> > > > > > > > The design of the code is simply to remove the link to the
> > > > > > > > inserted device which has been removed.
> > > > > > > > 
> > > > > > > > I*think*  this means the calls to device_del and device_add
> > > > > > > > are unnecessary and should go.  enclosure_remove_links and
> > > > > > > > the put of the enclosed device should be sufficient.
> > > > > > > 
> > > > > > > That would make more sense than trying to "reuse" the device
> > > > > > > structure here by tearing it down and adding it back.
> > > > > > 
> > > > > > OK, let's try that.  This should be the patch if someone can try
> > > > > > it (I've compile tested it, but the enclosure system is under a
> > > > > > heap of stuff in the garage).
> > > > > 
> > > > > I can test it now.
> > > > > 
> > > > 
> > > > Yeah, that looks to have worked ok. SES disk locate was also fine
> > > > after losing and rediscovering the disk.
> > > 
> > > OK, I'll spin up a patch with fixes/reported and tested tags.
> > 
> > Did this get sent?  I can't seem to find it :(
> > 
> 
> Yeah, but you were not cc'ed :(
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200114&id=529244bd1afc102ab164429d338d310d5d65e60d

Hey, less work for me, that's fine!  :)

thanks for the poitner.

greg k-h