Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5368886ybl; Tue, 14 Jan 2020 07:51:27 -0800 (PST) X-Google-Smtp-Source: APXvYqxDsAfBggj/hEbLVw2op+oNk2vW1RO2V0cG9ipp9lpCJdMLCuON3PXSh5x5hkOkj07GsFP4 X-Received: by 2002:aca:4b14:: with SMTP id y20mr16327327oia.160.1579017087744; Tue, 14 Jan 2020 07:51:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1579017087; cv=pass; d=google.com; s=arc-20160816; b=x71lmX8TreAUdZOVJeYwJGZA7FqUetwuPbcx4p/7/Kt9ghNdCd2QFD9NWQeVC2q2CJ FbBcdZ+TMlW7q7a+SH/TCz3rX3mJKxTyCu2N62Qk3Pa+YFbnpARVIbzxva8JmFURmDa1 Cp6QXdj4tSYBkYjalrGedDaEzRngxrm2WpGdUTZt1HFTXygi/5R6+c3Y6qRMv4kHbr8a v0tyF3XV1FJWp+JYoimRJCm7kfcFqKDq79+k12vHanzVbqQWXknAemN93QpY6bXTjgrd b7FwIgZHgi5V1G/QFxgutY0+ubG4vZyPbhxOcbQuTfnQnImMjOXrVtKtC23Cey+urPWY EHOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=JNSSkFgpoKbc2ONZH1qRFjTrq2JGXe5sX/UD6hO+1w8=; b=C+i1/h9a1ZLLkuRL9Bfd4OojHMEHbs9NbMCn1VbSlg1Q+m/BIKU0CtwNmNdQRxMTWf 33DOThxmRZ7FiNpcFs9l45cTk6NMhOC9hrakhmGiOIEwaVtAkG7EFiQ4qXHrnOyAyzD3 /K7hH3PpQvPLkpu2g41S6PYb95wEMbkVmrhGQP3tQ3Yu7nezVFdvy8c1+ZNhiZYUPotF NQiC+2yLOvs+ESpSBiXPBfwkXcJOUog6NqGjbV45VUu6hrZnfNO47Vnln2USMNj/Da7W Rxgf6fvSnscyEYiVV2jXVmZSDsNOE3t7DGQLc502vcbPBT3AoAohhATEU3bLJDO+/Zjy Iciw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=sY55AYus; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r22si8123865otn.192.2020.01.14.07.51.16; Tue, 14 Jan 2020 07:51:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector1 header.b=sY55AYus; arc=pass (i=1 spf=pass spfdomain=mellanox.com dkim=pass dkdomain=mellanox.com dmarc=pass fromdomain=mellanox.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728558AbgANPu0 (ORCPT + 99 others); Tue, 14 Jan 2020 10:50:26 -0500 Received: from mail-db8eur05on2069.outbound.protection.outlook.com ([40.107.20.69]:34529 "EHLO EUR05-DB8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726365AbgANPu0 (ORCPT ); Tue, 14 Jan 2020 10:50:26 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IRZTThC6Q3XNurCqbD31vCRJ4LibatzkdFguWnikcvr26f+5yVUS5hwSyfPLUUx9W+TusNU4whoUNAYp58B2qtsyMV/Yx4ZMWmLAxOqzsIT0j0ejmFONtddoIG5YG9k9+6BKR1tnyqAT3HX29XL++uNaih+O19Ml3NATmPkza2i9k/pU+8Yn4cR47PTdZ+nYJP+uN/n3/GzvyNnTLRHmsheY1Op+1K6brdiHYfAfGxFsfKZXLE2knPeXXz3DTVDbs6LLDtxHMfVttBmZpjZAjrtf0nUSPiQJU3m4f+arQvRrSiAR03UPBxYT+vqI3b2RdAwjFz0Me6/cWsIN4gAFGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNSSkFgpoKbc2ONZH1qRFjTrq2JGXe5sX/UD6hO+1w8=; b=VgiOzcU9HXRwwtA/3+PYbqWESnPH1JlGbMxn84aX0rfG1HFe6OWXx7sY9Rt1fZFnS1mxtpqJkyllBM/Btrbz4igvMfnWLHnO7mzjkK5riUj2MEhNvJ/blB5kjxEEYrRMeJGpTi4J9mtFfg1e/zWAXA7qdu6KjnRtX/RuJgx5WERpNvMM/FOgdUcIokjJ58yw82Z4rNID+NPsh3s+w9bhKaF5HIrfC2xfGNbwcfBOEdCy7KzM6c54Gz7mG6kHaF6D7TGjwLKDo3nF/UhBGCUgI/9H9hMQm3YLOY7yEurEOz49kR2K69dZheosICDDeHbwpECBaUdvGfH8daAM8wWIbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNSSkFgpoKbc2ONZH1qRFjTrq2JGXe5sX/UD6hO+1w8=; b=sY55AYuskC+VPZbJLHAeLjwHrOEdyfN7pi/GdnchJneyO+nTG33FlKM29pX7fXHQpV9Lw/vSnm4EBwDADdMkeqOzM7HC0IYo7pGqgYnuKUjAQzRS76+vDJeKnVV78Fm5qopAr7KbXWiyiio9aZt+lOYc9YL/NRBQpUyAB1VNVKw= Received: from DB6PR0501MB2712.eurprd05.prod.outlook.com (10.172.225.17) by DB6PR0501MB2727.eurprd05.prod.outlook.com (10.172.225.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Tue, 14 Jan 2020 15:50:22 +0000 Received: from DB6PR0501MB2712.eurprd05.prod.outlook.com ([fe80::9477:3768:6a86:a578]) by DB6PR0501MB2712.eurprd05.prod.outlook.com ([fe80::9477:3768:6a86:a578%10]) with mapi id 15.20.2623.017; Tue, 14 Jan 2020 15:50:22 +0000 From: Asmaa Mnebhi To: Colin King , Corey Minyard , Arnd Bergmann , Greg Kroah-Hartman , Vadim Pasternak , "openipmi-developer@lists.sourceforge.net" CC: "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write Thread-Topic: [PATCH][next] drivers: ipmi: fix off-by-one bounds check that leads to a out-of-bounds write Thread-Index: AQHVyuiVmzgaQueLj0y17rR9L9rt1afqTq+w Date: Tue, 14 Jan 2020 15:50:22 +0000 Message-ID: References: <20200114144031.358003-1-colin.king@canonical.com> In-Reply-To: <20200114144031.358003-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Asmaa@mellanox.com; x-originating-ip: [216.156.69.42] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c856f1c5-b437-4680-e249-08d799097717 x-ms-traffictypediagnostic: DB6PR0501MB2727:|DB6PR0501MB2727: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 028256169F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(189003)(199004)(86362001)(33656002)(26005)(52536014)(9686003)(55016002)(478600001)(4326008)(53546011)(66946007)(8676002)(110136005)(64756008)(66476007)(66556008)(316002)(66446008)(81156014)(81166006)(186003)(6506007)(76116006)(8936002)(54906003)(2906002)(5660300002)(7696005)(71200400001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0501MB2727;H:DB6PR0501MB2712.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3KFBMJu6B9u/oMNtlgYdZKyt3VFXf4wosQWC3LmA+UPQk4rENeuQL7//CW+gYifoNSVepHc/ENCnrWCqzEiptYhR4N0N0rfDWFM0y3LYSH77ppvm1H0p91iKsKw9qMXeL4bz6bqBASI0+IGjI8321toH4+R8tSvgjoagtHJr2rcdbDgqte7myqUXMWKUfcC1SRJ2ytqMwQT0tto2snzrhAZ45SHtM47aQFGxYLnnyM7wlywIQx0QJ6nByh1jTmmmSPRjIcKnKdMrxV2kYkBMCywfeZjnT4zS+UbwYMv2OBmgdWyogfKafQuX4DRM8Vcj+If2aZfDqUGN5uaGztCgxbmp3Z1KE4o1/FmiKw0CASAG0A/RfBKddcxmMbfLSESTQfeg2IMwCK+wpMJdVL2Dn9Rpv4n6BwWf+KE9EO4bWLkeU4oDu9XTVxdpEpGGfW0h Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c856f1c5-b437-4680-e249-08d799097717 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 15:50:22.6834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0ZInj7s8Oro9skoyIuM2w/Oztcntc5stBsAD5sWPKRbHsYfxz8RGlnKjHg1Ygdfk1uIo1YK7HU4l8GM9xojOOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0501MB2727 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org UmV2aWV3ZWQtYnk6IEFzbWFhIE1uZWJoaSA8YXNtYWFAbWVsbGFub3guY29tPg0KDQotLS0tLU9y aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogQ29saW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmlj YWwuY29tPiANClNlbnQ6IFR1ZXNkYXksIEphbnVhcnkgMTQsIDIwMjAgOTo0MSBBTQ0KVG86IENv cmV5IE1pbnlhcmQgPGNtaW55YXJkQG12aXN0YS5jb20+OyBBcm5kIEJlcmdtYW5uIDxhcm5kQGFy bmRiLmRlPjsgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz47 IFZhZGltIFBhc3Rlcm5hayA8dmFkaW1wQG1lbGxhbm94LmNvbT47IEFzbWFhIE1uZWJoaSA8QXNt YWFAbWVsbGFub3guY29tPjsgb3BlbmlwbWktZGV2ZWxvcGVyQGxpc3RzLnNvdXJjZWZvcmdlLm5l dA0KQ2M6IGtlcm5lbC1qYW5pdG9yc0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2Vy Lmtlcm5lbC5vcmcNClN1YmplY3Q6IFtQQVRDSF1bbmV4dF0gZHJpdmVyczogaXBtaTogZml4IG9m Zi1ieS1vbmUgYm91bmRzIGNoZWNrIHRoYXQgbGVhZHMgdG8gYSBvdXQtb2YtYm91bmRzIHdyaXRl DQoNCkZyb206IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+DQoNClRo ZSBlbmQgb2YgYnVmZmVyIGNoZWNrIGlzIG9mZi1ieS1vbmUgc2luY2UgdGhlIGNoZWNrIGlzIGFn YWluc3QgYW4gaW5kZXggdGhhdCBpcyBwcmUtaW5jcmVtZW50ZWQgYmVmb3JlIGEgc3RvcmUgdG8g YnVmW10uIEZpeCB0aGlzIGFkanVzdGluZyB0aGUgYm91bmRzIGNoZWNrIGFwcHJvcHJpYXRlbHku DQoNCkFkZHJlc3Nlcy1Db3Zlcml0eTogKCJPdXQtb2YtYm91bmRzIHdyaXRlIikNCkZpeGVzOiA1 MWJkNmYyOTE1ODMgKCJBZGQgc3VwcG9ydCBmb3IgSVBNQiBkcml2ZXIiKQ0KU2lnbmVkLW9mZi1i eTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCi0tLQ0KIGRyaXZl cnMvY2hhci9pcG1pL2lwbWJfZGV2X2ludC5jIHwgMiArLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9jaGFyL2lw bWkvaXBtYl9kZXZfaW50LmMgYi9kcml2ZXJzL2NoYXIvaXBtaS9pcG1iX2Rldl9pbnQuYw0KaW5k ZXggOWZkYWU4M2U1OWUwLi4zODJiMjhmMWNmMmYgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL2NoYXIv aXBtaS9pcG1iX2Rldl9pbnQuYw0KKysrIGIvZHJpdmVycy9jaGFyL2lwbWkvaXBtYl9kZXZfaW50 LmMNCkBAIC0yNzksNyArMjc5LDcgQEAgc3RhdGljIGludCBpcG1iX3NsYXZlX2NiKHN0cnVjdCBp MmNfY2xpZW50ICpjbGllbnQsDQogCQlicmVhazsNCiANCiAJY2FzZSBJMkNfU0xBVkVfV1JJVEVf UkVDRUlWRUQ6DQotCQlpZiAoaXBtYl9kZXYtPm1zZ19pZHggPj0gc2l6ZW9mKHN0cnVjdCBpcG1i X21zZykpDQorCQlpZiAoaXBtYl9kZXYtPm1zZ19pZHggPj0gc2l6ZW9mKHN0cnVjdCBpcG1iX21z ZykgLSAxKQ0KIAkJCWJyZWFrOw0KIA0KIAkJYnVmWysraXBtYl9kZXYtPm1zZ19pZHhdID0gKnZh bDsNCi0tDQoyLjI0LjANCg0K