Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
CC:     "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH 1/3] mfd: da9062: fix watchdog compatible string
Thread-Topic: [PATCH 1/3] mfd: da9062: fix watchdog compatible string
Thread-Index: AQHVxgoH+VEwCd0goUCdzD0vjKNBfafqYIMg
Date:   Tue, 14 Jan 2020 16:19:04 +0000
Message-ID: <AM6PR10MB2263E53D89F7EC66C5E3779D80340@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
References: <20200108095704.23233-1-m.felsch@pengutronix.de>
 <20200108095704.23233-2-m.felsch@pengutronix.de>
In-Reply-To: <20200108095704.23233-2-m.felsch@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 20f9947f-a04a-4f11-4e5f-08d7990d7975
x-ms-traffictypediagnostic: AM6PR10MB2518:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR10MB2518FAE2E4E7604D1EE00E58A7340@AM6PR10MB2518.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:3276;
x-forefront-prvs: 028256169F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(189003)(199004)(26005)(55016002)(54906003)(71200400001)(8936002)(110136005)(8676002)(9686003)(81166006)(81156014)(55236004)(6506007)(53546011)(7696005)(498600001)(52536014)(86362001)(76116006)(66446008)(66476007)(66946007)(64756008)(33656002)(66556008)(186003)(2906002)(5660300002)(4326008);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR10MB2518;H:AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: DIxcMtydyy7HJbqhoBe6a9p1EtFmrVVIq8+22rDFg0qrn3dK3i+hyxrm7S5I8ig4y/esYdNjSl4UK0VdSaaRA0uzpGzjNmFrdWng1glIUYwXWyLU5D7xLymbDvbzmD0MgoGcdRsYnU/IrGkENxWL/B3huol1m53PfPm5B+Yvl471w5mhSpga3kIYoFnEwnb511EWivg/JvaMTIsZjq+0z1kp5wZD47oPaRlI8TwzZKpMaxeQCOyK7N8TrKrI5eyHsJCADmW6ocWlDbeki+Ojf92hYFMOLl/HT4n8vzPZlA72xV45pNWznyT6K9qAEQ/GaFhoCHIzvKk89OFPAEB9ED4y1o+pi+WcAA3SAAf3hICy0dKPeXxYH7RgxlTE+yiB2i2lxf6PflouQRjw8U9D36KrF1TEbkCsdiKK8aP1NYm2dxabrIljNOPDPi6dpy6v
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20f9947f-a04a-4f11-4e5f-08d7990d7975
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 16:19:04.6010
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jYl8qDO9c1BnaSk0CLzNCC8LugoIOvff5lL5Kd7oE7IQ2FiCAPyhEL8eb7citcWXIhfkig1OqK4OSwhqfJUhv9Va4fLjd0I1lLd0IKFSP1s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2518
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08 January 2020 09:57, Marco Felsch wrote:

> The watchdog driver compatible is "dlg,da9062-watchdog" and not
> "dlg,da9062-wdt". Therefore the mfd-core can't populate the of_node and
> fwnode. As result the watchdog driver can't parse the devicetree.
>=20

I do agree there's a mismatch between the documentation and the MFD code.
So in your DT are you specifying 'dlg,da9062-watchdog' and not 'dlg,da9062-=
wdt'
hence the issue? Are there any existing users who are using 'dlg,da9062-wdt=
' in
their DT instead?

> Fixes: 9b40b030c4ad ("mfd: da9062: Supply core driver")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  drivers/mfd/da9062-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index e69626867c26..9143de7b77b8 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -248,7 +248,7 @@ static const struct mfd_cell da9062_devs[] =3D {
>  		.name		=3D "da9062-watchdog",
>  		.num_resources	=3D ARRAY_SIZE(da9062_wdt_resources),
>  		.resources	=3D da9062_wdt_resources,
> -		.of_compatible  =3D "dlg,da9062-wdt",
> +		.of_compatible  =3D "dlg,da9062-watchdog",
>  	},
>  	{
>  		.name		=3D "da9062-thermal",
> --
> 2.20.1