Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Support Opensource <Support.Opensource@diasemi.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
CC:     "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH 3/3] watchdog: da9062: add power management ops
Thread-Topic: [PATCH 3/3] watchdog: da9062: add power management ops
Thread-Index: AQHVxgoI80GM0h8rl02lD5uhhW9tpKfqYSMg
Date:   Tue, 14 Jan 2020 16:24:39 +0000
Message-ID: <AM6PR10MB2263254FB395E307C777DBDE80340@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
References: <20200108095704.23233-1-m.felsch@pengutronix.de>
 <20200108095704.23233-4-m.felsch@pengutronix.de>
In-Reply-To: <20200108095704.23233-4-m.felsch@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: eec37010-e0cd-4ada-69c7-08d7990e40d4
x-ms-traffictypediagnostic: AM6PR10MB2726:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR10MB2726E949BA84C327477A03C0A7340@AM6PR10MB2726.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:2449;
x-forefront-prvs: 028256169F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39850400004)(346002)(189003)(199004)(64756008)(478600001)(2906002)(4326008)(66556008)(66476007)(66446008)(66946007)(316002)(110136005)(54906003)(76116006)(55236004)(52536014)(26005)(8936002)(6506007)(53546011)(5660300002)(81156014)(8676002)(86362001)(81166006)(186003)(55016002)(9686003)(71200400001)(7696005)(33656002)(6606295002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR10MB2726;H:AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Doy7jHxljcYk60Rb4wSivmT2GUDQCxQGC84ZRbiMFeeHS2c877x9/wsxQVWXyQ7HTmyUo6XFAcciSy36MHwqJ9OIzOb+TU5eRM4QQlvYClr9+nx8k7DB4BHntIQ9XuoVRv7QbVvresNFhbnOWgz8nbRRmZju1H+GeG+5pQuG0qHOxHQMMYwIsGb9CGXtdq1cz8WkFEKPkevkOstPIrGPq1fsDkYFtrXMyE20GAjCK0uB2lkOC3mxRmV1kdX9eXgMJOfRtMHdrOx+2lGamfohCt1QewceSjdcNsnbikQvDMk+efl43hsiSjU6zkL6B56k90W7sgH8lSPiLytDx2Cz0VkdIqTU19KhPuKk4Bn+y8b1K76Hya2WYBXDkNFbe0Oy1AZ+7O3TYjRT4cEV0CYN75etT7mKpXAeoIkwoW70odTqFAwfZlej56Lcpe3rxbAErVrH1mDZR/2Rnddhfe1vLKyqK3DaMJ31EJ6l2acrnIWu9Ow59MWeAL8DqVWIU6x4
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eec37010-e0cd-4ada-69c7-08d7990e40d4
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 16:24:39.0909
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wbRY4TDHC+i6bDMSQpWdw65HvvJzzVbtkeC/ZeLQWLd78XSYvE8UXTh4YMFcKIuXggdWpUAR/b03FbBf2Ufbd/DL++S9yzNq5idZ2h6FywY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2726
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08 January 2020 09:57, Marco Felsch wrote:

> Disable the watchdog during suspend if it is enabled and re-enable it on
> resume. So we can sleep without the interruptions.
>=20
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

> ---
> v2:
> - add dlg,use-sw-pm check to differentiate between automatic and manual
>   disabling/enabling.
> ---
>  drivers/watchdog/da9062_wdt.c | 37
> +++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>=20
> diff --git a/drivers/watchdog/da9062_wdt.c b/drivers/watchdog/da9062_wdt.=
c
> index e149e66a6ea9..c9b9d6394525 100644
> --- a/drivers/watchdog/da9062_wdt.c
> +++ b/drivers/watchdog/da9062_wdt.c
> @@ -15,6 +15,7 @@
>  #include <linux/jiffies.h>
>  #include <linux/mfd/da9062/registers.h>
>  #include <linux/mfd/da9062/core.h>
> +#include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/of.h>
>=20
> @@ -30,6 +31,7 @@ static const unsigned int wdt_timeout[] =3D { 0, 2, 4, =
8, 16, 32,
> 65, 131 };
>  struct da9062_watchdog {
>  	struct da9062 *hw;
>  	struct watchdog_device wdtdev;
> +	bool use_sw_pm;
>  };
>=20
>  static unsigned int da9062_wdt_timeout_to_sel(unsigned int secs)
> @@ -198,6 +200,8 @@ static int da9062_wdt_probe(struct platform_device
> *pdev)
>  	if (!wdt)
>  		return -ENOMEM;
>=20
> +	wdt->use_sw_pm =3D device_property_present(dev, "dlg,use-sw-pm");
> +
>  	wdt->hw =3D chip;
>=20
>  	wdt->wdtdev.info =3D &da9062_watchdog_info;
> @@ -212,6 +216,7 @@ static int da9062_wdt_probe(struct platform_device
> *pdev)
>  	watchdog_set_restart_priority(&wdt->wdtdev, 128);
>=20
>  	watchdog_set_drvdata(&wdt->wdtdev, wdt);
> +	dev_set_drvdata(dev, &wdt->wdtdev);
>=20
>  	ret =3D devm_watchdog_register_device(dev, &wdt->wdtdev);
>  	if (ret < 0)
> @@ -220,10 +225,42 @@ static int da9062_wdt_probe(struct platform_device
> *pdev)
>  	return da9062_wdt_ping(&wdt->wdtdev);
>  }
>=20
> +static int __maybe_unused da9062_wdt_suspend(struct device *dev)
> +{
> +	struct watchdog_device *wdd =3D dev_get_drvdata(dev);
> +	struct da9062_watchdog *wdt =3D watchdog_get_drvdata(wdd);
> +
> +	if (!wdt->use_sw_pm)
> +		return 0;
> +
> +	if (watchdog_active(wdd))
> +		return da9062_wdt_stop(wdd);
> +
> +	return 0;
> +}
> +
> +static int __maybe_unused da9062_wdt_resume(struct device *dev)
> +{
> +	struct watchdog_device *wdd =3D dev_get_drvdata(dev);
> +	struct da9062_watchdog *wdt =3D watchdog_get_drvdata(wdd);
> +
> +	if (!wdt->use_sw_pm)
> +		return 0;
> +
> +	if (watchdog_active(wdd))
> +		return da9062_wdt_start(wdd);
> +
> +	return 0;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(da9062_wdt_pm_ops,
> +			 da9062_wdt_suspend, da9062_wdt_resume);
> +
>  static struct platform_driver da9062_wdt_driver =3D {
>  	.probe =3D da9062_wdt_probe,
>  	.driver =3D {
>  		.name =3D "da9062-watchdog",
> +		.pm =3D &da9062_wdt_pm_ops,
>  		.of_match_table =3D da9062_compatible_id_table,
>  	},
>  };
> --
> 2.20.1