Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5409275ybl; Tue, 14 Jan 2020 08:27:56 -0800 (PST) X-Google-Smtp-Source: APXvYqwEb5GgmLUI0DsPZBu8lZtzNyQQSe3Pw7S8A+OG5z6XSa0zSLPuz9hOwib5rTpF/r940sAD X-Received: by 2002:a9d:4e92:: with SMTP id v18mr16390607otk.47.1579019276550; Tue, 14 Jan 2020 08:27:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1579019276; cv=pass; d=google.com; s=arc-20160816; b=SVlFAF3WXGmFSlFfBnE9ZNc8N/CINHY1QuuZhykyKaOFcslpPcisYtKRPQq21AeShX 1onSfb9hO3Yve9WQl/GiRmgNvEAeja6PBxWc/5naV1kCpKsUevze8CCk8MDMDRr6/ueD rvlQyKipUgiz8yL4L4Zd1IZrPMaHJ53E3QL9sNmCDNHlMLgDMu6micPTRgyxmS9dybvu Kq+Xu7MnZg6cvwkwlZjWQIAUd58v1cna/ezOJzex1OHN4BADvsjg8jnMj7rQA+lJZhRF 2hnKmZe8wVUEKoXwQdMM/Ko6VuSy0AE2ASB4oCq9Kex5r6I39ZTRes85FCR/eYANTRu4 1uGQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:content-language:accept-language:in-reply-to:references :message-id:date:thread-index:thread-topic:subject:cc:to:from :dkim-signature; bh=QHy/C5++OemYKYAG8zWr6nCPTuRvwJJfOwocbfcEbHc=; b=TPHK6KasHppd3oOFU+fdBVQJpRgiSzLa0EievXN4ybjQV9UF0lq0Ka00060VHqRzh5 s/nVfMoIfy8OLRip2QkTuFFj+7SwU5jw0tv7CXF7W7e59pihxIHrcEW5jniihZrW6aTC rMJ5QYbTNDYEcYVxX28Nvo/RcA/26RDyXafHoyNdxeuThdJzI1fcxUinzLwc1Vet0dze jDXSST2NyKOL+AWUORUlzM6PB9Y3TG6R+l2m58NG+AXgc0RyEW7KX5KeskYKrZLBf6qj qay8erYyf4d5Pu50FixW3nk3sWvpuI7FMwrtzkXSfAU/F+rpFqCUMHC3oaR5Lg4Vbahw 0t1Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infinera.com header.s=selector2 header.b=IfdDcPIP; arc=pass (i=1 spf=pass spfdomain=infinera.com dkim=pass dkdomain=infinera.com dmarc=pass fromdomain=infinera.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=infinera.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a205si7742147oii.95.2020.01.14.08.27.45; Tue, 14 Jan 2020 08:27:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@infinera.com header.s=selector2 header.b=IfdDcPIP; arc=pass (i=1 spf=pass spfdomain=infinera.com dkim=pass dkdomain=infinera.com dmarc=pass fromdomain=infinera.com); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=infinera.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbgANQ0f (ORCPT + 99 others); Tue, 14 Jan 2020 11:26:35 -0500 Received: from mail-dm6nam10on2050.outbound.protection.outlook.com ([40.107.93.50]:6027 "EHLO NAM10-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725904AbgANQ0e (ORCPT ); Tue, 14 Jan 2020 11:26:34 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QCSBwrcYeKcA9zkIFq8U/cH3np3uqHS2nWR2Y71HiiIpL7eFRV3PRoBFAEn2nkX/raLmaBgVyYfQdrAZSuZ+/h6OUDcfP8dNKs+j1+bHsBGYrT0qwT7Kyahipl32es3cOwzVdrqEPtZqqtBuQmn62W6yWvLdT8NysNJJJddpaYyiIFYFXMu0ZyFde4WqSAkel4E6iUqYF2kdLebR8OhTuWrTdxglIB3CWryYP577STKrk2LTt+HsBpKLcRlY4JdpHnTxim+HZGr6jzBrMns4O9tAPhPRJDoyklYhfzkurcUcHT/yiGeKq+TqV91BRDDv0H8mtHu7qgZ5wGyTzOnrEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHy/C5++OemYKYAG8zWr6nCPTuRvwJJfOwocbfcEbHc=; b=bT95sRS6/E9Z0t31l7Q8zMCrp0oqRRBFJ1ial5ozVK8Hho679rmfpAoGO6aM6eIVrlb/Ac4aFG2nAvdI3hF4wMs92BQI8hyKSKIBbUF7wMoxbXbbcy+RcBagutFHJ5+4RWR4kXE+c+MDARVPNjNi/YgMn2i/1OpdqI/O72Tov88HIy3HqJV72b3/Uzt/gfN2G7Uh1FGA3I2Viq1L8BlxKI8cu7t3qB3M0d1DjJ8sCIR0jXuedZIWNf1MpgJZv3eZIjHPeuLJtgl0xzVS6qOFjaN+TADgrw505gKr7BQSc2HOT7DPCZlWnMZuoFvwzGB0ru0FC/+0s/2VGU1fw1gI8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=infinera.com; dmarc=pass action=none header.from=infinera.com; dkim=pass header.d=infinera.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infinera.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHy/C5++OemYKYAG8zWr6nCPTuRvwJJfOwocbfcEbHc=; b=IfdDcPIP6e8L0EogBpxhGyYbYo/DrvKPABgSEzVo3ODnRwHrF+2SQLfbUeefmfX/bZVA4kvLzRFVNIKvv/tlu1PBjU3NtV6VMMDcwDHe/xk8YaCwQfoZXjUQSXhevk4AMaHXw7BBiBM2jXEXaEzipIW9D5ln3fY2f8sdPCfORJo= Received: from BN8PR10MB3540.namprd10.prod.outlook.com (20.179.77.152) by BN8PR10MB3524.namprd10.prod.outlook.com (20.179.79.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Tue, 14 Jan 2020 16:26:18 +0000 Received: from BN8PR10MB3540.namprd10.prod.outlook.com ([fe80::6922:a072:d75e:74ef]) by BN8PR10MB3540.namprd10.prod.outlook.com ([fe80::6922:a072:d75e:74ef%7]) with mapi id 15.20.2623.017; Tue, 14 Jan 2020 16:26:18 +0000 From: Joakim Tjernlund To: "christophe.leroy@c-s.fr" , "broonie@kernel.org" CC: "linux-spi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lkp@intel.com" , "geert@linux-m68k.org" Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe() Thread-Topic: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe() Thread-Index: AQHVyvSaV4B/R2znCEqweeHE7izY96fqWMiA Date: Tue, 14 Jan 2020 16:26:18 +0000 Message-ID: References: <2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.leroy@c-s.fr> In-Reply-To: <2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.leroy@c-s.fr> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Joakim.Tjernlund@infinera.com; x-originating-ip: [88.131.87.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fc679e57-a0a1-4f2b-e643-08d7990e7bc9 x-ms-traffictypediagnostic: BN8PR10MB3524: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 028256169F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(366004)(136003)(376002)(346002)(39860400002)(199004)(189003)(6506007)(4326008)(5660300002)(6486002)(6512007)(36756003)(66476007)(66556008)(478600001)(64756008)(8936002)(81166006)(81156014)(8676002)(2906002)(66446008)(76116006)(91956017)(66946007)(71200400001)(316002)(54906003)(26005)(86362001)(2616005)(186003)(110136005);DIR:OUT;SFP:1101;SCL:1;SRVR:BN8PR10MB3524;H:BN8PR10MB3540.namprd10.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: infinera.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cfP5hGgiG2GVd4C0ge3c6tp2HCcYKSmkM1m3QSvBoXpOFO2j+CyfF/kAlePXm759PuzzCC1d4rhiacDw/XsiBDJV/cr7c1VFug4dreXo2e5fMZy2uy4zSYzxe+cGfedkwreWhOErUD4YEEW/stqODPOvvHOoX41SX3crwaVse9Tvj/26jn6GAGiNf1v70SA1oWqYeXkJWXlc/F+tD9UKd0hgY0sGgpBhOBqSf3TjkPbTcruzRkbjgeKBFfCRW4ADt1d2ND5veqemrDJbAqx6+aIHLrXyRfUHrID5XNGeXxOoCA9kFpp2spckILibO7RrtF9HWCnm2wgJLiHMqTtprNkvycvdOjM5f8EbT2iB7lBPltcv/zRIZ4f3b/iP2vFGvdNA2Nzrbw8cgNoe27GIOPHcXcUvgaCJWWtJyXo1ygYiRDdQbVSYByuYMNhZYYCH x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <75EE43E45520CF4BBC8B477E9A2C63F7@namprd10.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: infinera.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc679e57-a0a1-4f2b-e643-08d7990e7bc9 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 16:26:18.0556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 285643de-5f5b-4b03-a153-0ae2dc8aaf77 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j8kzUAkVImhXUWvrGTWmaeeL+9YiJJfW3Yjzbpdw4uuEcnvRuHJjt9S1Dgw2vPikP+mt9XHOW1LM/BXBnyBPfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3524 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVHVlLCAyMDIwLTAxLTE0IGF0IDE2OjAyICswMDAwLCBDaHJpc3RvcGhlIExlcm95IHdyb3Rl Og0KPiBDQVVUSU9OOiBUaGlzIGVtYWlsIG9yaWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIHRoZSBv cmdhbml6YXRpb24uIERvIG5vdCBjbGljayBsaW5rcyBvciBvcGVuIGF0dGFjaG1lbnRzIHVubGVz cyB5b3UgcmVjb2duaXplIHRoZSBzZW5kZXIgYW5kIGtub3cgdGhlIGNvbnRlbnQgaXMgc2FmZS4N Cj4gDQo+IA0KPiBObyBuZWVkIHRvICdnb3RvIGVycjsnIGZvciBqdXN0IGRvaW5nIGEgcmV0dXJu Lg0KPiByZXR1cm4gZGlyZWN0bHkgZnJvbSB3aGVyZSB0aGUgZXJyb3IgaGFwcGVucy4NCj4gDQo+ IFNpZ25lZC1vZmYtYnk6IENocmlzdG9waGUgTGVyb3kgPGNocmlzdG9waGUubGVyb3lAYy1zLmZy Pg0KPiAtLS0NCj4gdjM6IHJlYmFzZSBvbiB0b2RheSdzIHNwaS9mb3ItbmV4dCBhbmQgdXNpbmcg UFRSX0VSUl9PUl9aRVJPKCkgaW4gb25lIHBsYWNlLg0KPiAtLS0NCj4gIGRyaXZlcnMvc3BpL3Nw aS1mc2wtc3BpLmMgfCAyNyArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gIDEgZmlsZSBj aGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvc3BpL3NwaS1mc2wtc3BpLmMgYi9kcml2ZXJzL3NwaS9zcGktZnNsLXNwaS5j DQo+IGluZGV4IGZiNDE1OWFkNmJmNi4uM2I4MTc3MmZlYTBkIDEwMDY0NA0KPiAtLS0gYS9kcml2 ZXJzL3NwaS9zcGktZnNsLXNwaS5jDQo+ICsrKyBiL2RyaXZlcnMvc3BpL3NwaS1mc2wtc3BpLmMN Cj4gQEAgLTcwNiw4ICs3MDYsOCBAQCBzdGF0aWMgaW50IG9mX2ZzbF9zcGlfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqb2ZkZXYpDQo+ICAgICAgICAgc3RydWN0IGRldmljZV9ub2RlICpu cCA9IG9mZGV2LT5kZXYub2Zfbm9kZTsNCj4gICAgICAgICBzdHJ1Y3Qgc3BpX21hc3RlciAqbWFz dGVyOw0KPiAgICAgICAgIHN0cnVjdCByZXNvdXJjZSBtZW07DQo+IC0gICAgICAgaW50IGlycSA9 IDAsIHR5cGU7DQo+IC0gICAgICAgaW50IHJldCA9IC1FTk9NRU07DQo+ICsgICAgICAgaW50IGly cSwgdHlwZTsNCj4gKyAgICAgICBpbnQgcmV0Ow0KPiANCj4gICAgICAgICByZXQgPSBvZl9tcGM4 eHh4X3NwaV9wcm9iZShvZmRldik7DQo+ICAgICAgICAgaWYgKHJldCkNCj4gQEAgLTcyMiwxMCAr NzIyLDggQEAgc3RhdGljIGludCBvZl9mc2xfc3BpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKm9mZGV2KQ0KPiANCj4gICAgICAgICAgICAgICAgIGlmIChzcGlzZWxfYm9vdCkgew0KPiAg ICAgICAgICAgICAgICAgICAgICAgICBwaW5mby0+aW1tcl9zcGlfY3MgPSBpb3JlbWFwKGdldF9p bW1yYmFzZSgpICsgSU1NUl9TUElfQ1NfT0ZGU0VULCA0KTsNCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgaWYgKCFwaW5mby0+aW1tcl9zcGlfY3MpIHsNCj4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICByZXQgPSAtRU5PTUVNOw0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdvdG8gZXJyOw0KPiAtICAgICAgICAgICAgICAgICAgICAgICB9DQo+ICsgICAgICAgICAg ICAgICAgICAgICAgIGlmICghcGluZm8tPmltbXJfc3BpX2NzKQ0KPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOw0KPiAgICAgICAgICAgICAgICAgfQ0KPiAg I2VuZGlmDQo+ICAgICAgICAgICAgICAgICAvKg0KPiBAQCAtNzQ0LDI0ICs3NDIsMTUgQEAgc3Rh dGljIGludCBvZl9mc2xfc3BpX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKm9mZGV2KQ0K PiANCj4gICAgICAgICByZXQgPSBvZl9hZGRyZXNzX3RvX3Jlc291cmNlKG5wLCAwLCAmbWVtKTsN Cj4gICAgICAgICBpZiAocmV0KQ0KPiAtICAgICAgICAgICAgICAgZ290byBlcnI7DQo+ICsgICAg ICAgICAgICAgICByZXR1cm4gcmV0Ow0KPiANCj4gICAgICAgICBpcnEgPSBwbGF0Zm9ybV9nZXRf aXJxKG9mZGV2LCAwKTsNCj4gLSAgICAgICBpZiAoaXJxIDwgMCkgew0KPiAtICAgICAgICAgICAg ICAgcmV0ID0gaXJxOw0KPiAtICAgICAgICAgICAgICAgZ290byBlcnI7DQo+IC0gICAgICAgfQ0K PiArICAgICAgIGlmIChpcnEgPCAwKQ0KPiArICAgICAgICAgICAgICAgcmV0dXJuIGlycTsNCj4g DQo+ICAgICAgICAgbWFzdGVyID0gZnNsX3NwaV9wcm9iZShkZXYsICZtZW0sIGlycSk7DQo+IC0g ICAgICAgaWYgKElTX0VSUihtYXN0ZXIpKSB7DQo+IC0gICAgICAgICAgICAgICByZXQgPSBQVFJf RVJSKG1hc3Rlcik7DQo+IC0gICAgICAgICAgICAgICBnb3RvIGVycjsNCj4gLSAgICAgICB9DQo+ IC0NCg0KRG9uJ3QgeW91IG5lZWQgdG8gInVuZG8iIGlvcmVtYXAsIGlycSBldGMuIGluIGNhc2Ug b2YgbGF0ZXIgZXJyb3JzPw0KDQo+IC0gICAgICAgcmV0dXJuIDA7DQo+IA0KPiAtZXJyOg0KPiAt ICAgICAgIHJldHVybiByZXQ7DQo+ICsgICAgICAgcmV0dXJuIFBUUl9FUlJfT1JfWkVSTyhtYXN0 ZXIpOw0KPiAgfQ0KPiANCj4gIHN0YXRpYyBpbnQgb2ZfZnNsX3NwaV9yZW1vdmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqb2ZkZXYpDQo+IC0tDQo+IDIuMTMuMw0KPiANCg0K