Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To:     Marco Felsch <m.felsch@pengutronix.de>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
CC:     Support Opensource <Support.Opensource@diasemi.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        Steve Twiss <stwiss.opensource@diasemi.com>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [PATCH 1/3] mfd: da9062: fix watchdog compatible string
Thread-Topic: [PATCH 1/3] mfd: da9062: fix watchdog compatible string
Thread-Index: AQHVxgoH+VEwCd0goUCdzD0vjKNBfafqYIMggAABdYCAAACmIA==
Date:   Tue, 14 Jan 2020 16:28:40 +0000
Message-ID: <AM6PR10MB22632546AC9A4466B642BEFD80340@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
References: <20200108095704.23233-1-m.felsch@pengutronix.de>
 <20200108095704.23233-2-m.felsch@pengutronix.de>
 <AM6PR10MB2263E53D89F7EC66C5E3779D80340@AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM>
 <20200114162359.weoirknje6yhcmds@pengutronix.de>
In-Reply-To: <20200114162359.weoirknje6yhcmds@pengutronix.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [165.225.80.228]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 41845e66-6efb-473a-5dc1-08d7990ed0d8
x-ms-traffictypediagnostic: AM6PR10MB2726:
x-ms-exchange-sharedmailbox-routingagent-processed: True
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM6PR10MB2726222D05CF0690C4049704A7340@AM6PR10MB2726.EURPRD10.PROD.OUTLOOK.COM>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-forefront-prvs: 028256169F
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(366004)(376002)(396003)(39860400002)(346002)(189003)(199004)(64756008)(966005)(478600001)(2906002)(4326008)(66556008)(66476007)(66446008)(66946007)(316002)(110136005)(54906003)(76116006)(55236004)(52536014)(26005)(8936002)(6506007)(53546011)(5660300002)(81156014)(8676002)(86362001)(81166006)(186003)(55016002)(9686003)(71200400001)(7696005)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR10MB2726;H:AM6PR10MB2263.EURPRD10.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:0;
received-spf: None (protection.outlook.com: diasemi.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: UY0ETwwWB1NC4jQJjjIyRfZgLyPA0HocCW7OweiydhtyjTfulqfcb6Gii7m9AGLpur6kaPBFzdeuwN6ZFDolbywaB6FSkyOzJuA6mh/OPe2s+J3oduf2O9k1JQn1itn+IWTiyK+IMLfRsuVKEAcLynyiLdjH5KQkBEJku/+OJxAwXOO0Q7OtSR3n11sWbOOiK8JMecT4PXCnbm3HO679+TvehW+sW057MarOt3imA+6cwnALlRXfT4ZIEAEcSZ+/ahOFiNFa5de91/AO15shTLd7T1qsmcb/dNbqBQucQkxpWg/eMXFbafmCw/KHVGAHARfs6oI0QC+W8kZ4cac+Csor21+FlEbskNUj7JOSIeeQ5GIwG1cnaX8modneSBT9fDScmAZQTIHl6/qqDKybKO8Z++25cx7AxXkjRBB0oCZbIi/s39FFIhWfQ0xkdh9tOho9tFwibhOVvJNznRMDOsWLPuzjPgpEISB0AAkh0qDB3otgvVndRQwE/KSDPAs8A1P61u37IuY5ED5Jn0BeRQ==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: diasemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41845e66-6efb-473a-5dc1-08d7990ed0d8
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2020 16:28:40.7757
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 511e3c0e-ee96-486e-a2ec-e272ffa37b7c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xrlcAF6X62ThIJJxqBw3QYFfX5s1g24k7hBeL1xqlEqPTAq6iNRJY+NV2Gm49gsomItKfz42l63GrwV/ET5k3CKQcNHmyuqV1InPQcYzhdI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR10MB2726
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14 January 2020 16:24, Marco Felsch wrote:

> On 20-01-14 16:19, Adam Thomson wrote:
> > On 08 January 2020 09:57, Marco Felsch wrote:
> >
> > > The watchdog driver compatible is "dlg,da9062-watchdog" and not
> > > "dlg,da9062-wdt". Therefore the mfd-core can't populate the of_node a=
nd
> > > fwnode. As result the watchdog driver can't parse the devicetree.
> > >
> >
> > I do agree there's a mismatch between the documentation and the MFD cod=
e.
> > So in your DT are you specifying 'dlg,da9062-watchdog' and not 'dlg,da9=
062-wdt'
> > hence the issue? Are there any existing users who are using 'dlg,da9062=
-wdt' in
> > their DT instead?
>=20
> Yes the upstream available DT I'm currently using is:
> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi.
>=20
> I grep the code and found no _upstream_ user of 'dlg,da9062-wdt' also
> using this compatible would be a missmatch with the binding
> documentation. So those DT's assuming a wrong binding. Therefore I fixed
> it here and not within the watchdog driver.

Ok, no problem. Just wanted to be clear. In which case:

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

>=20
> Regards,
>   Marco
>=20
> > > Fixes: 9b40b030c4ad ("mfd: da9062: Supply core driver")
> > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > > ---
> > >  drivers/mfd/da9062-core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> > > index e69626867c26..9143de7b77b8 100644
> > > --- a/drivers/mfd/da9062-core.c
> > > +++ b/drivers/mfd/da9062-core.c
> > > @@ -248,7 +248,7 @@ static const struct mfd_cell da9062_devs[] =3D {
> > >  		.name		=3D "da9062-watchdog",
> > >  		.num_resources	=3D ARRAY_SIZE(da9062_wdt_resources),
> > >  		.resources	=3D da9062_wdt_resources,
> > > -		.of_compatible  =3D "dlg,da9062-wdt",
> > > +		.of_compatible  =3D "dlg,da9062-watchdog",
> > >  	},
> > >  	{
> > >  		.name		=3D "da9062-thermal",
> > > --
> > > 2.20.1
> >
> >
>=20
> --
> Pengutronix e.K.                           |                             =
|
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  =
|
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    =
|
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 =
|