Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5439495ybl; Tue, 14 Jan 2020 08:58:54 -0800 (PST) X-Google-Smtp-Source: APXvYqxrXC7KjwDlwTv75n3YqvYMzAs0XA1FGMrRT7HGbZM2yOleblQmx+L8qOg6U4e0/+D+ZawG X-Received: by 2002:aca:4306:: with SMTP id q6mr17901974oia.54.1579021134416; Tue, 14 Jan 2020 08:58:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579021134; cv=none; d=google.com; s=arc-20160816; b=FOwDx9mBKtpqL7MZ60K/iMIRS9EdvajLDubP0uHtTATug2PkegLmGNG6hGkRWfaEKC q5i7IxzTBbBUoGTtflcg29ZnNzcF5e9te06RsuiKi3eLSVvh5O65O8dSl7oQ2kga0Fnb 77zyRWmn5/7vK29TM9cpU5lNJbmVQjMsEr4LyIHK2I7xuCEcbz9IM2fZzFw06ESI5GUX GcJKlIauZ2lYASUPrVyNkcgrGKYUlTBHU2Nlr6SUGqN7h2QMAwJiZbA1SgS4bH2/SxjY p0fWNG/enULEKMWjgzQkj5A6tGXDU6uphytaEyK9QfUKd0OxWv5WpBab8RtPWCgBadRh y0fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=I7zCUFSxCilOiygfJOrKMG+d9QBWeV+zMVpsSsqTMqc=; b=rwHl4JQrSKkpSHnndC0tDmuVLdMeV2LlBGGRQ4+0bLcZ6SPSZQu0dLEgDuuZnagcno xP9VmzfjeZhCtn5N/wNFBsl+JrJNRA4Tpmyfs/3gTv8JHWwJH3uFX9Qi2emGYCydcBH9 DNbiY4nqcwf/LhDX8Z8kGjRrapFR13pJyoSPn7KtBdXiQYGm6LM5l9AgiAYPGYP6SoNT P20I3XS2aHgnEmmXxXd0mXRnvIUS0VwkbORANS5MgLtB9RLlSJJEvovnd9oHF/5x1J8q VPoT/0CTUZAtg77t6wfGo+XctweN4u8bAyvEzEUh8cZWY36EfrZafVo8s0K1qb6+euMR Yzyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kWHKHJJ6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p62si7552254oig.101.2020.01.14.08.58.42; Tue, 14 Jan 2020 08:58:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=kWHKHJJ6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728755AbgANQ5u (ORCPT + 99 others); Tue, 14 Jan 2020 11:57:50 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:34292 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726195AbgANQ5t (ORCPT ); Tue, 14 Jan 2020 11:57:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I7zCUFSxCilOiygfJOrKMG+d9QBWeV+zMVpsSsqTMqc=; b=kWHKHJJ6ilFEWZ2bNlW/Xb26V zGRDUEUZTnDadH1LnqM1ADZMn4ilWGec89HluanPHUxhNrpUyJ3xZqFAI5s2Q4E86vFSN9IF7T4Nf gKE/KbbvYrjzJ3hSOsZPEkWNhP/YMZAWYoawaW2j8vSPiJajqf9hZ0l7gGfmHbxfE3+PY=; Received: from fw-tnat-cam7.arm.com ([217.140.106.55] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irPVc-0001hW-7R; Tue, 14 Jan 2020 16:57:40 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id ACA3ED01965; Tue, 14 Jan 2020 16:57:39 +0000 (GMT) Date: Tue, 14 Jan 2020 16:57:39 +0000 From: Mark Brown To: Joakim Tjernlund Cc: "christophe.leroy@c-s.fr" , "linux-spi@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lkp@intel.com" , "geert@linux-m68k.org" Subject: Re: [PATCH v3] spi: fsl: simplify error path in of_fsl_spi_probe() Message-ID: <20200114165739.GC3897@sirena.org.uk> References: <2a4a7e11b37cfa0558d68f0d35e90d6da858b059.1579017697.git.christophe.leroy@c-s.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="avNtfD0ffNO6L/9g" Content-Disposition: inline In-Reply-To: X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --avNtfD0ffNO6L/9g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 14, 2020 at 04:26:18PM +0000, Joakim Tjernlund wrote: > Don't you need to "undo" ioremap, irq etc. in case of later errors? Better, convert to devm_=20 --avNtfD0ffNO6L/9g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4d8wIACgkQJNaLcl1U h9DBpgf/ZMWk7TuStHKbaJC0YfEaWwp2D/yVzYAISxxSeNvL25vQlQlFJe6YGYR0 2KK5vLMxNaH1Vf6vhet00ClpsdinZt7Jx91tzaplblsKxlPbraf4tSs6USCdy5Iq kSgUDnJvxiQSMnoTjJOkMh/ee/2LJQtVnYB+XirIqI9YWfqAZLrgm/PfqUnNq5vG +g9nCJ3/RKsLQGb9VmbmXwMy5gVCj3u41aMoX9XDDgoayy1IZPWRIsBTIzUmmCLZ A5OhXxnxucHDkAMXjiHE+jmgPEC1LUV+JIBydgN7Z+ryBNvTeLXDTFbnavabBb3Q RaQCF+kEphOgL9A5QfgIkwmkUwtCtg== =SVwD -----END PGP SIGNATURE----- --avNtfD0ffNO6L/9g--