Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: regulator: mpq7920: Some inconsistencies in current driver
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <CAFRkauBRi2g_4b3wUnmwLkeogTyWjX4=6VfyDLJr-REf=LeC-w@mail.gmail.com>
From:   saravanan sekar <sravanhome@gmail.com>
Message-ID: <673bbb3e-70e1-db4e-239e-3fedbbfdd5ad@gmail.com>
Date:   Tue, 14 Jan 2020 18:44:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <CAFRkauBRi2g_4b3wUnmwLkeogTyWjX4=6VfyDLJr-REf=LeC-w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 14/01/20 1:49 pm, Axel Lin wrote:
> Hi Saravanan,
>
> There are a few inconsistencies in current driver:
> I don't have the datasheet, so I'm not 100% sure.
> Maybe you can help check it.
>
> 1. It's unlikely MPQ7920_LDO1_REG_B and MPQ7920_REG_CTL0 have the same address.
>     I think this needs double check.

There is no REG_B register for MPQ7920_LDO1, it is a tweak for MACRO expansion consistence of MPQ7920LDO.
However LDO1 doesn't not access this register since mpq7920_ldortc_ops discharge api is set to NULL

> 2. The MPQ7920_DISCHARGE_ON seems wrong because it does not match
> MPQ7920_MASK_DISCHARGE.
>     I guess MPQ7920_DISCHARGE_ON should be BIT(5).
Yes, you are correct and thanks for pointing out
>
> 3. The MPQ7920_MASK_BUCK_ILIM seems wrong. I guess it should be 0xC0.

Yes, you are correct and thanks for pointing out

> 4. Not sure why define both MPQ7920_REG_REGULATOR_EN1 and
> MPQ7920_REG_REGULATOR_EN.
There is EN1 register exist but later decided that cannot be handled by 
driver so its stray which
shall be removed.
>
> Regards,
> Axel

Thanks,
Saravanan