Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to
 follow huge
To:     Wei Yang <richardw.yang@linux.intel.com>,
        <akpm@linux-foundation.org>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
References: <20200113070322.26627-1-richardw.yang@linux.intel.com>
From:   Ralph Campbell <rcampbell@nvidia.com>
Message-ID: <3ec77382-900c-56b9-dcad-f8b24117b097@nvidia.com>
Date:   Tue, 14 Jan 2020 11:07:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.0
MIME-Version: 1.0
In-Reply-To: <20200113070322.26627-1-richardw.yang@linux.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 1/12/20 11:03 PM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

I had thought about doing this same thing. :-)
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>

> ---
>   mm/gup.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
>   	pmdval = READ_ONCE(*pmd);
>   	if (pmd_none(pmdval))
>   		return no_page_table(vma, flags);
> -	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> +	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
>   		page = follow_huge_pmd(mm, address, pmd, flags);
>   		if (page)
>   			return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
>   	pud = pud_offset(p4dp, address);
>   	if (pud_none(*pud))
>   		return no_page_table(vma, flags);
> -	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> +	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
>   		page = follow_huge_pud(mm, address, pud, flags);
>   		if (page)
>   			return page;
>