Message-ID: <43DE2730.795468DC@tv-sign.ru>
Date: Mon, 30 Jan 2006 17:48:16 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
MIME-Version: 1.0
To: "Eric W. Biederman" <ebiederm@xmission.com>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] exec: Cleanup exec from a non thread group leader.
References: <43DDFDE3.58C01234@tv-sign.ru>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 801
Lines: 23

Oleg Nesterov wrote:
> 
> Eric W. Biederman wrote:
> >
> > -     list_add_tail(&thread->tasks, &init_task.tasks);
> 
> The last deletion is wrong, I beleive.

Just to clarify, it looks like we can kill this line because
de_thread() also does list_add_tail(current, &init_task.tasks).

But please note that it (and probably __ptrace_link() above)
does list_del(current->task) first, and current->task may have
very stale values after old leader called dup_task_struct().
SET_LINKS() in copy_process() does nothing with ->tasks in a
CLONE_THREAD case.

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/