Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5694366ybl; Tue, 14 Jan 2020 13:23:10 -0800 (PST) X-Google-Smtp-Source: APXvYqx3r/UlQSRhL1Py04PnnS0VM2TNaoMm5As4KdaQ75Ju8u/rAtiglFuM8eFxH3VKDQr4kNaW X-Received: by 2002:a05:6830:1251:: with SMTP id s17mr299101otp.108.1579036990250; Tue, 14 Jan 2020 13:23:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579036990; cv=none; d=google.com; s=arc-20160816; b=LNU+X3R8uD7MSoLFEJ/KT8JZzO18cDMdVjbBp3TVh6dIVpgega7g6Qo3K7iqqcsEt3 mCwtiVVbRg8dFb6RS8HGi1C0evIFztgMdY1nP1D3tMKXd+vuTJFfbciuKrcmrGhBZSw+ uIDl61TVsz8TQ7fjqs+uk0k23bKjYohK+VltLmNnw4ac3npZtcN1y0745U9uIgsTtW6T s+xj0iTDYtjQil/cNAE5CbQebtvAJyWdtthFTRYq2bCO8VWW+fHpDYgqmyElAkjEhNF9 ZPZUZNeLecoDUy5EjarLxcca9o4ia66L7aaWZJiFjmTUCN2C6SG1a1Z8BcTaMJM8cMs1 qivg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=9eRDwWbU1kM/KQ1EnxnHFDhoHc135Zk+JzAs+cc4Ho8=; b=eamQx1EjE162u2tFqueP9svuLVNOFSDHy1ha/zay2FOySGrP+qT3aVxh5TpaHbPJvL m4toLtVcYYpms8YCPc9U8n7rso+xSgZgijgqV5W0j3hoSiVFHmL5GCLrJi500nlf+SB3 g+k6liOlmWFs6oKq/c3Lm9ZWBxcbsxkr27xlOPcJ2Qi7l1JFH+2MtFkAlQ/LkMLOMfd5 0t7et+IHC0/JRyoEHPM/NPl8uXOWc2n+AMhcd9FdYBkNrViJYbIIb/THoFBNANPxqLlu vtWxyNYk5BKyU54U17gDidL57EkB8ncy2XxgHpplEKtObVLg9wpEDI2LxWKdDfkBd36O dwdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k131si8052352oia.64.2020.01.14.13.22.54; Tue, 14 Jan 2020 13:23:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728874AbgANVVZ (ORCPT + 99 others); Tue, 14 Jan 2020 16:21:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:50632 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728748AbgANVVY (ORCPT ); Tue, 14 Jan 2020 16:21:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id B3AA5AE5E; Tue, 14 Jan 2020 21:21:21 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 39208DA795; Tue, 14 Jan 2020 22:21:08 +0100 (CET) Date: Tue, 14 Jan 2020 22:21:07 +0100 From: David Sterba To: Kusanagi Kouichi Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: Implement lazytime Message-ID: <20200114212107.GM3929@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Kusanagi Kouichi , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200114085325045.JFBE.12086.ppp.dion.ne.jp@dmta0008.auone-net.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114085325045.JFBE.12086.ppp.dion.ne.jp@dmta0008.auone-net.jp> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2020 at 05:53:24PM +0900, Kusanagi Kouichi wrote: > I tested with xfstests and lazytime didn't cause any new failures. The changelog should describe what the patch does (the 'why' part too, but this is obvious from the subject in this case). That fstests pass without new failures is nice but there should be a specific test for that or instructions in the changelog how to test.