Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5733731ybl; Tue, 14 Jan 2020 14:07:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxRM7ZcTStT35ztTJjp3AYzWLKAyGz1Pep1Mf9JKxsSeom52GxZtlpg0TO8Hh7b5Mk6q3ZE X-Received: by 2002:a54:4e08:: with SMTP id a8mr19186266oiy.77.1579039662141; Tue, 14 Jan 2020 14:07:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579039662; cv=none; d=google.com; s=arc-20160816; b=b5gA+y0cfD77o8fEAe0Z6359nxDLfT7hpkYSb82svSG3g4JGhyfUX7SjX1bJM4fSz7 AHh0E2rbBt0xVRKnQoLKuKllMEKoMccBSvyWARWdxwEccW5hN/nHa35yqAuBmedFmzRD Od61CHWN6A9Wc4obc96yAjnaJJoaH309mcBboadEU4GIj94z3cxuD5JCmEIPZur6a+fI fqig2RCFPO76ktoiZJPHKcfStucwJZH9hWyoikc6RZSIlZBdklH6xWbMpfMjyURLN4dh 0RH2K7x7pR1yXkLI2IUvwwbYbbbwmNx+vnV7y373wPJOw4KX37iVepfFMYqPeN+Kkr4W daTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=ak2pDlNLJqO6I6B08zZGpFxARQfKyArhMmTzeALdBzg=; b=bRbpHEKIT4AWENqRvyMiEozrzlS2kFJEzVLn6GAIA1CrA0FOsKLyCSg9xwmCBoKFPT /KjMJcBJG3Zo8XNTaJ6Eece819ccdOwe/9sC609fypUn5aLZB1fwJbJ3OSvWknamAsUN gUquc+KXe541yNXbRwEAOFwRjizi/IxVLBr00SXxGoBZE3inY3H7x8FPi2yrj/jBvOX7 nvI6/n6aghzR/4NY4+sUbfXkH48wgTEKRVvHpmjWrk22gt5aDqOg+In7hYCs7tKxARcl x74qcuq7s5dsq9lOVfxaItIWXBf/jcUEZUT+aK1keB90XOiZ6sNaqC8d9pD+iS0p1m7c aMvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cCHYW6a6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c126si8056096oib.239.2020.01.14.14.07.29; Tue, 14 Jan 2020 14:07:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cCHYW6a6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728753AbgANWG0 (ORCPT + 99 others); Tue, 14 Jan 2020 17:06:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:45674 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727102AbgANWG0 (ORCPT ); Tue, 14 Jan 2020 17:06:26 -0500 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D6A42467A; Tue, 14 Jan 2020 22:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579039585; bh=ak2pDlNLJqO6I6B08zZGpFxARQfKyArhMmTzeALdBzg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cCHYW6a6nJENELdOdK6d5nUAFMYQgVeYuz0JQ2jjuOWRxbT6HzRipISp8KrAwsE/u F/vedVKRrWV1TGVEFP49MpODow/BWFG/HfxVyMOseoLizNfjTCK+IV0hg2gGnBtLiF agiqjC7Y7MER9MoUJUEyXAw7L8s6/5hGa5SBtf1A= Received: by mail-qv1-f45.google.com with SMTP id dp13so6443169qvb.7; Tue, 14 Jan 2020 14:06:25 -0800 (PST) X-Gm-Message-State: APjAAAUC0xIx0b9UnZe4i1mzE7Endwv1r8JAa+1+RwflJkU+aj0HmUmj lqDi2M+8TCfSYopIYp2tZpI11scoEJ84BBKszw== X-Received: by 2002:ad4:450a:: with SMTP id k10mr21746759qvu.136.1579039584558; Tue, 14 Jan 2020 14:06:24 -0800 (PST) MIME-Version: 1.0 References: <20200114213809.27166-1-jbx6244@gmail.com> In-Reply-To: <20200114213809.27166-1-jbx6244@gmail.com> From: Rob Herring Date: Tue, 14 Jan 2020 16:06:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v1 1/3] dt-bindings: mmc: combine common mmc and dw-mshc properties To: Johan Jonker Cc: Ulf Hansson , Mark Rutland , "heiko@sntech.de" , linux-mmc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 14, 2020 at 3:38 PM Johan Jonker wrote: > > Combine the common properties for mmc and dw-mshc in > mmc-controller-common.yaml Commit messages should explain the why, not what. AFAICT, the only reason is to not have a node name of 'mmc'. That's entirely the reason why it is defined. Fix your node names to use the standard name. Rob