Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 14 Jan 2020 14:55:12 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@sifive.com>
To:     Greentime Hu <greentime.hu@sifive.com>
cc:     Gt <green.hu@gmail.com>, greentime@kernel.org,
        Palmer Dabbelt <palmer@dabbelt.com>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andreas Schwab <schwab@suse.de>,
        Anup Patel <anup@brainfault.org>
Subject: Re: [PATCH v3] riscv: make sure the cores stay looping in
 .Lsecondary_park
In-Reply-To: <CAHCEehKchrwd7TTmSrhtEPeCmkrYrx7TX_c6ogpCpSkCKnBQoQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.9999.2001141449500.21279@viisi.sifive.com>
References: <20200109031516.29639-1-greentime.hu@sifive.com> <alpine.DEB.2.21.9999.2001091126480.135239@viisi.sifive.com> <alpine.DEB.2.21.9999.2001121011100.160130@viisi.sifive.com> <CAHCEehKchrwd7TTmSrhtEPeCmkrYrx7TX_c6ogpCpSkCKnBQoQ@mail.gmail.com>
User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Greentime,

On Tue, 14 Jan 2020, Greentime Hu wrote:

> I think it is because the sections are too far for bqeu to jump and
> the config I used just small enough for it to jump so I didn't see
> this bug. Sorry about that.

No problem.

> I tried this fix to boot in Unleashed board.
> 
>  #ifdef CONFIG_SMP
>         li t0, CONFIG_NR_CPUS
> -       bgeu a0, t0, .Lsecondary_park
> +       blt a0, t0, .Lgood_cores
> +       tail .Lsecondary_park
> +.Lgood_cores:
>  #endif

Looks reasonable to me.  Care to update and repost the patch?


- Paul