Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5955170ybl; Tue, 14 Jan 2020 18:34:36 -0800 (PST) X-Google-Smtp-Source: APXvYqw6jHSnxNuSq5coSxEMG66AN+j6vtEWVcSVR3C9N8m/ESmu1rcjqVCGXMz9fYxQVuTn2gnk X-Received: by 2002:a05:6830:184:: with SMTP id q4mr1199280ota.232.1579055676741; Tue, 14 Jan 2020 18:34:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579055676; cv=none; d=google.com; s=arc-20160816; b=nA/H4l3fIMfELiH21ndrF/5XORRaXedb6dFXR5VuhaCiXRSQqlpJPitqlJpG0/MVNN XX6lfY6H5EygoobserdOj3NZF8QHv2EXpTUoFG8pQdngaGUFEDgdEWy4Hht+3bZ1zEDz mPycZryS21L5B2BNl2azTekbL7fFNFhWgRUn0T6ENfUoB3Ahfj7iBodlh2qeXtblTrmu 3jGTNxUyb4KzgUxxSQEh2X/bhm2/qC/W73EG4OSol6+oatyKd1UALbxPOm4SBgwK6RWs QvcMN86//Eu8lTrMxhMrEU1zw1dxD101tH89gkrheL/CZm0couxEZ/k5bc03jMK/0Op1 MtiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=zf/Znm+0pHWQDbKwunPpQ7yyMAbPPEkjf1CNnAZtGdg=; b=paLGt5iDCbOQXShOMsPdrRxj5pnKXDo2Yxm3SIUGQABDxIYwNU0eW+iKuIooAfHXIQ 9Y4AVPd3/7eZQn1zPNEOlX9LdM+lu2MDlACIKfFlyoN2NVEJGacErrmxf3Rkl0VBKHrN rUI1glICMGfCAax7odUpcuIu1i9Mp9iMk5YJN/Y7ZX1z4CMOYBDUdB/Mg3e7g8P/EVbP JarF5eC83AaWgHcRawUHKB+EfLnB2vppCkd5hgZu4n0m+Pi5Sqy5i417M7wnOBN03R5c 4W2bWNH1nki6LrJ2J49nPX3NirqjJD9Kk0N3lFkBW7u5XdZH1qrxW9/Ji63EUHmAfolq ZnBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si11600766otg.248.2020.01.14.18.34.25; Tue, 14 Jan 2020 18:34:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728961AbgAOCdd (ORCPT + 99 others); Tue, 14 Jan 2020 21:33:33 -0500 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:42602 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728862AbgAOCdc (ORCPT ); Tue, 14 Jan 2020 21:33:32 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R761e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Tnlx2xO_1579055609; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0Tnlx2xO_1579055609) by smtp.aliyun-inc.com(127.0.0.1); Wed, 15 Jan 2020 10:33:30 +0800 Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page To: Qian Cai Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1579006500-127143-1-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: <739f4470-8dfe-bb2f-8100-2134f48868b6@linux.alibaba.com> Date: Wed, 15 Jan 2020 10:31:59 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/1/14 ????9:46, Qian Cai ะด??: > > >> On Jan 14, 2020, at 7:55 AM, Alex Shi wrote: >> >> This macro are never used in git history. So better to remove. > > When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit. > Thanks fore reminder, Qian! This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or commiter could be found. Thanks Alex