Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: vnqB2gez3U2mI1uMe/5jB2TFUQ9H8d4bRqg8HhCv8FE26x0wfehyRHm9acPzncyT37uPfU0QYB
 1bC4tnn4FylcRkYnsIZrgLhVvUw1SOIMvuyuypvjHPXA7c1wpfDu5BgaC+Ki4roIp7irLLODBy
 AdTvJ4kzj5Agz8I9J51wmzZvmuyVPyxektVKnyE1SGZNfJHoQ98AnR79xP3jTTb1BuEhCQN1Rt
 S1HfsY78/kb9obOmhicRC/Uc8dx1fSliBARE7B6Za+YPLhJKpBnAE8u/XfCBHw2bdNqdjLcDXP
 LX8=
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Yuehaibing <yuehaibing@huawei.com>
CC:     Chao Yu <yuchao0@huawei.com>,
        "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'cs_block'
Thread-Topic: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'cs_block'
Thread-Index: AQHVulgQExCdjuBytUKA1yv69qLf+qfLyO2AgAAnP4CAACbggIAfDJoA
Date:   Wed, 15 Jan 2020 02:33:28 +0000
Message-ID: <20200115023328.bummaaa7pdnao5qk@shindev.dhcp.fujisawa.hgst.com>
References: <20191224124359.15040-1-yuehaibing@huawei.com>
 <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com>
 <62ce1981-9061-f798-a65d-9599ceceb4b8@huawei.com>
 <20191226082419.ljbhystwkhp2d4gh@shindev.dhcp.fujisawa.hgst.com>
In-Reply-To: <20191226082419.ljbhystwkhp2d4gh@shindev.dhcp.fujisawa.hgst.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-ID: <564B674AF41E8540BE93E33C34484B50@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 339d4532-60f2-484f-4d8f-08d799634e3a
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 02:33:28.8680
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QX7kIdKKvuHxnFfJPEjEjq/4Ho6rlRO4ZKQA+q2xZdrvakFen2i9VUN1Hd6xTTSbE17q6EdrUNMZ+bkOlwkxO9CfFkAo8rzBR7rVx0DmRs4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR04MB2266
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Dec 26, 2019 / 17:24, Shin'ichiro Kawasaki wrote:
> On Dec 26, 2019 / 14:05, Yuehaibing wrote:
> > On 2019/12/26 11:44, Chao Yu wrote:
> > > On 2019/12/24 20:43, YueHaibing wrote:
> > >> fs/f2fs/segment.c: In function fix_curseg_write_pointer:
> > >> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not us=
ed [-Wunused-but-set-variable]
> > >>
> > >> It is never used since commit 362d8a920384 ("f2fs: Check
> > >> write pointer consistency of open zones") , so remove it.
> > >=20
> > > Thanks for the fix!
> > >=20
> > > Do you mind merging this patch to original patch? as it's still
> > > pending in dev branch.
> >=20
> > It's ok for me.
> >
>=20
> Thank you for this catch and the fix. Appreciated.

I have merged YueHaibing's change to the write pointer consistency fix patc=
h
and sent out as the v6 series. Thanks again for finding out the unused vari=
able.

I was not sure if I should add Chao Yu's reviewed by tag to the patch from =
which
the unused variable was removed. To be strict, I didn't add the tag. Just
another quick review by Chao will be appreciated.

--
Best Regards,
Shin'ichiro Kawasaki=