Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Fix display of Maximum Memory
To:     Michael Bringmann <mwb@linux.ibm.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     Gustavo Walbon <gwalbon@linux.ibm.com>,
        Paul Mackerras <paulus@samba.org>
References: <55f25626-20ca-0acb-3571-ff636ca4632c@linux.ibm.com>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
Message-ID: <41380afd-05f5-f36f-c857-041243c73ee3@c-s.fr>
Date:   Wed, 15 Jan 2020 06:41:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <55f25626-20ca-0acb-3571-ff636ca4632c@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Le 14/01/2020 à 22:07, Michael Bringmann a écrit :
> Correct overflow problem in calculation+display of Maximum Memory
> value to syscfg where 32bits is insufficient.
> 
> Signed-off-by: Michael Bringmann <mwb@linux.ibm.com>
> ---
>   arch/powerpc/platforms/pseries/lparcfg.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/lparcfg.c b/arch/powerpc/platforms/pseries/lparcfg.c
> index 4ee2594..183aeb7 100644
> --- a/arch/powerpc/platforms/pseries/lparcfg.c
> +++ b/arch/powerpc/platforms/pseries/lparcfg.c
> @@ -435,12 +435,12 @@ static void parse_em_data(struct seq_file *m)
> 
>   static void maxmem_data(struct seq_file *m)
>   {
> -       unsigned long maxmem = 0;
> +       unsigned long long maxmem = 0;

What about using u64 instead, for readability ?

> 
> -       maxmem += drmem_info->n_lmbs * drmem_info->lmb_size;
> -       maxmem += hugetlb_total_pages() * PAGE_SIZE;
> +       maxmem += (unsigned long long)drmem_info->n_lmbs * (unsigned long long)drmem_info->lmb_size;

This line is likely too long. You only need to cast one of the two 
operants to force a 64 bits multiply. And using u64 would shorten the line.

Can both multiplications overflow ?

Christophe

> +       maxmem += (unsigned long long)hugetlb_total_pages() * (unsigned long long)PAGE_SIZE;
> 
> -       seq_printf(m, "MaxMem=%ld\n", maxmem);
> +       seq_printf(m, "MaxMem=%llu\n", maxmem);
>   }
> 
>   static int pseries_lparcfg_data(struct seq_file *m, void *v)
>