Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp6113772ybl; Tue, 14 Jan 2020 22:11:15 -0800 (PST) X-Google-Smtp-Source: APXvYqzQHBrrIJmfTxyNG9e+bxJAKf/QC/GVXu7WfqsezKizdFWvpLJNM4tPztrhIFSwB7KN0kZ6 X-Received: by 2002:a9d:7616:: with SMTP id k22mr1680139otl.364.1579068675277; Tue, 14 Jan 2020 22:11:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579068675; cv=none; d=google.com; s=arc-20160816; b=jLnbuU7xJT6s4F2W63uMlrah+ro/SwLw0IFvXLVdWyA+FIYldH836osecI0lIEku6f /uhXCzEf8T6CHKtvPbIEicZraq6sArXEuJH1paKXWLd+HUDTezZQgvfIv/b59b9uUIj0 1PE930fam/tKPHSpGw1CoaU1xBZAfqJ1kYETdHxGqkO1lJCeD09Bfvegvpa6GRP0IOyX 1zowPo8wHs4OZTmvR7mnpDWAe+NdHLtNduQSZJOX1KX24dmIEyzt8fWDLRzGDwQ28dPJ 8S9fA02XLJtzRuxUm3cztrW9u2Ikd7FG2JP7D2W6loqjqnVK+f3uDvZflg+NmS/6QPz/ NCCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=pRznptztnXQm7MwVGKpzEIUWd9UEUauX4vvE2jIG5tk=; b=l36lxtva7x3XGcHMWIxjPRwDPjxCEmLIVwHZs81tKliVDa4oEx0/5qoRy1NA/2dj63 6lfYUxB6b6fDVqUFKNfjWR80eM1blWRb+fl6ynMBeDDiq4oY+oFO4cB2HJWbiVNSbpdV RFAqquaGDksS+0Of13MeOr7KXasn78Os9KpelsXON72Glc/Quy78/+y7mp7gVJ9bNRBJ AzOLbclqvO9g+klkgXAFSgAtnMTd0lZHDu/ovmJawOy4GmTd9NNPfmXopSBIotll2yTE OevfbhwAxUfI8MUMW4rqGst9WzyTqmad4AqHAWGdkVa3UHm4BfMSRznuCpqGcZUu+cW1 PJXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l19si8508447oii.54.2020.01.14.22.10.56; Tue, 14 Jan 2020 22:11:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726088AbgAOGJi (ORCPT + 99 others); Wed, 15 Jan 2020 01:09:38 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:52727 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725962AbgAOGJi (ORCPT ); Wed, 15 Jan 2020 01:09:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0TnmuvRl_1579068565; Received: from localhost(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TnmuvRl_1579068565) by smtp.aliyun-inc.com(127.0.0.1); Wed, 15 Jan 2020 14:09:35 +0800 From: Yang Shi To: akpm@linux-foundation.org Cc: yang.shi@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() Date: Wed, 15 Jan 2020 14:09:25 +0800 Message-Id: <1579068565-110432-1-git-send-email-yang.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The VM_BUG_ON() is already used by queue_pages_test_walk(), it sounds better to dump more debug information by using VM_BUG_ON_VMA() to help debugging. Signed-off-by: Yang Shi --- mm/mempolicy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mempolicy.c b/mm/mempolicy.c index 067cf7d..801d45d 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -621,7 +621,7 @@ static int queue_pages_test_walk(unsigned long start, unsigned long end, unsigned long flags = qp->flags; /* range check first */ - VM_BUG_ON((vma->vm_start > start) || (vma->vm_end < end)); + VM_BUG_ON_VMA((vma->vm_start > start) || (vma->vm_end < end), vma); if (!qp->first) { qp->first = vma; -- 1.8.3.1