Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Jan 2020 08:19:57 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Stefan Lengfeld <contact@stefanchrist.eu>
Cc:     support.opensource@diasemi.com, linux@roeck-us.net,
        Adam.Thomson.Opensource@diasemi.com,
        linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@pengutronix.de
Subject: Re: [PATCH] watchdog: da9062: make restart handler atomic safe
Message-ID: <20200115071957.j7sptgbmuilgs2lj@pengutronix.de>
References: <20200113091521.5754-1-m.felsch@pengutronix.de>
 <20200114200034.nbk6vf77ucngfs6o@porty>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200114200034.nbk6vf77ucngfs6o@porty>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Stefan,

On 20-01-14 21:00, Stefan Lengfeld wrote:
> Hi Marco,
> 
> On Mon, Jan 13, 2020 at 10:15:21AM +0100, Marco Felsch wrote:
> > The restart handler is executed during the shutdown phase which is
> > atomic/irq-less. The i2c framework supports atomic transfers since
> > commit 63b96983a5dd ("i2c: core: introduce callbacks for atomic
> > transfers") but unfortunately the regmap framework doesn't support it
> > yet. Hard coding the i2c stuff can be done without worries since the
> > DA9062 is an i2c-only device.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> 
> Reviewed-by: Stefan Lengfeld <contact@stefanchrist.eu>
> 
> Thanks for picking up the patch and submitting it.

I will send a v2 to cover Guenter's suggestion. Can I keep your reviewed
by tag?

Regards,
  Marco

> Kind regards,
>     Stefan