Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Jayshri Pawar <jpawar@cadence.com>, linux-usb@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com,
        rogerq@ti.com, linux-kernel@vger.kernel.org, jbergsagel@ti.com,
        nsekhar@ti.com, nm@ti.com, peter.chen@nxp.com, kurahul@cadence.com,
        pawell@cadence.com, sparmar@cadence.com, jpawar@cadence.com
Subject: Re: [PATCH v2] usb: cdns3: Add streams support to cadence USB3 DRD driver
In-Reply-To: <1578733666-354-1-git-send-email-jpawar@cadence.com>
References: <1578733666-354-1-git-send-email-jpawar@cadence.com>
Date:   Wed, 15 Jan 2020 11:07:30 +0200
Message-ID: <87eew16qb1.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jayshri Pawar <jpawar@cadence.com> writes:
> This patch includes streams implementation changes.
> The current changes has been validated on FPGA platform.
>
> Enabled streams related interrupts only for streams capable endpoints.
> Processed  PRIME and IOT interrupts related to streams capable endpoints.
> Based on PRIME interrupt prime_flag is set and transfer is armed
> otherwise just adding request to the deferred request queue.
> For streams capable endpoints preparing TD with correct stream ID.
>
> TDL calculation:
> Updated tdl calculation based on controller versions.
> 1. For controller version DEV_VER_V2 :We have enabled USB_CONF2_EN_TDL_TRB
>    bit in usb_conf2 register in DMULT configuration.
>    This enables TDL calculation based on TRB, hence setting TDL in TRB.
> 2. For controller Version < DEV_VER_V2 : Writing TDL and STDL in ep_cmd
>    register
> 3. For controller version > DEV_VER_V2 : Writing TDL in ep_tdl register.

> Writing ERDY with correct Stream ID to ep_cmd register.
> Added stream id related information to trace logs.
>
> Signed-off-by: Jayshri Pawar <jpawar@cadence.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Signed-off-by: Rahul Kumar <kurahul@cadence.com>
> ---
>
> Version History:
> v2: Patch generated on top of linux-next.git master branch
>
>  drivers/usb/cdns3/gadget.c | 533 +++++++++++++++++++++++++++++++++----
>  drivers/usb/cdns3/gadget.h |  26 +-
>  drivers/usb/cdns3/trace.h  |  93 ++++++-
>  3 files changed, 596 insertions(+), 56 deletions(-)

This patch is enormous. Are you sure there's no way to break it down
into smaller pieces?

(Hint: there is)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAl4e1lIACgkQzL64meEa
mQYVOxAAxyx6gyof7t4YhI8gU6cxEASdvVcAhH1XX/0RYvzuGiWC1YrfS2c/rjMh
ieX6K+QHUmi46cL8T4HosQoHgd6X8cRQKMk8y2ovvgcEi7tXj7uMMMA4UJ9eso0x
iv1qxVX+nPZ0S4Kde9rYEhwArOYj98a4vrevT1wHbjJX7Iz0HV5U+m+qV2mLUukJ
DlvRXmh/xJB/6O69SmW0iZe97+5EWC3nJoicKLvE8X4wPHQKbok1rGA8/K4wgjr9
jxOmOvdvGbGQWT46Dha2OYtfhzOCd9wr00eFgtSmguIt9ZHGtMT6r4z32uKadI6b
g4bgvrY6b+IfU23eLu5UfG+/YxeZ5mZOH0j2lG9abG27p4xb43P3p9ljVMeeOFm9
JccVxY1IxHaYx0wgn+nyugow2YW2l+Iu9Mw6XyEcjdd2xrUMPt1+Os4USpvkOWFr
eJPO711lQtF9SWuTqqrtEi6QMuqpXKqOgPJROHYru8sOEmMQWmD9DcrTNca1WOA0
ks1zfCn+SfN8wxSQUkF/SEHD8XQTYAljuIpQgesp/L+Ld7xbCWM/CLgl7GcIjLQ9
TDIbYpktx4hiLKVcfmIVrMknxe2A46nRXlYIitPdfYQeWbLFQH4tNS2TSr1FS9iQ
Aa+09zKLoxZQ0jXwWggoXqC/60cjm4kjzDrXJ4mzlOGV2mhgJlY=
=BZ2r
-----END PGP SIGNATURE-----
--=-=-=--