Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable
 'cs_block'
To:     Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
        Yuehaibing <yuehaibing@huawei.com>
CC:     "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
        "chao@kernel.org" <chao@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-f2fs-devel@lists.sourceforge.net" 
        <linux-f2fs-devel@lists.sourceforge.net>
References: <20191224124359.15040-1-yuehaibing@huawei.com>
 <673efe18-d528-2e9b-6d44-a6a7a22086f3@huawei.com>
 <62ce1981-9061-f798-a65d-9599ceceb4b8@huawei.com>
 <20191226082419.ljbhystwkhp2d4gh@shindev.dhcp.fujisawa.hgst.com>
 <20200115023328.bummaaa7pdnao5qk@shindev.dhcp.fujisawa.hgst.com>
From:   Chao Yu <yuchao0@huawei.com>
Message-ID: <0aea7754-2114-cc78-3453-bc608bacd45a@huawei.com>
Date:   Wed, 15 Jan 2020 17:54:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200115023328.bummaaa7pdnao5qk@shindev.dhcp.fujisawa.hgst.com>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/1/15 10:33, Shinichiro Kawasaki wrote:
> On Dec 26, 2019 / 17:24, Shin'ichiro Kawasaki wrote:
>> On Dec 26, 2019 / 14:05, Yuehaibing wrote:
>>> On 2019/12/26 11:44, Chao Yu wrote:
>>>> On 2019/12/24 20:43, YueHaibing wrote:
>>>>> fs/f2fs/segment.c: In function fix_curseg_write_pointer:
>>>>> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable]
>>>>>
>>>>> It is never used since commit 362d8a920384 ("f2fs: Check
>>>>> write pointer consistency of open zones") , so remove it.
>>>>
>>>> Thanks for the fix!
>>>>
>>>> Do you mind merging this patch to original patch? as it's still
>>>> pending in dev branch.
>>>
>>> It's ok for me.
>>>
>>
>> Thank you for this catch and the fix. Appreciated.
> 
> I have merged YueHaibing's change to the write pointer consistency fix patch
> and sent out as the v6 series. Thanks again for finding out the unused variable.
> 
> I was not sure if I should add Chao Yu's reviewed by tag to the patch from which
> the unused variable was removed. To be strict, I didn't add the tag. Just
> another quick review by Chao will be appreciated.

Thanks for the revision. :)

I guess Jaegeuk can merge that kind of fix into original patch, and
meanwhile keeping old Reviewed-by tag in that patch.

Thanks,

> 
> --
> Best Regards,
> Shin'ichiro Kawasaki.
>