Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20200115082820epcas1p34ebebebaf610fd61c4e9882fca8ddbd5@epcas1p3.samsung.com>
 <20200115082447.19520-1-namjae.jeon@samsung.com> <20200115082447.19520-4-namjae.jeon@samsung.com>
In-Reply-To: <20200115082447.19520-4-namjae.jeon@samsung.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 15 Jan 2020 11:25:22 +0100
Message-ID: <CAK8P3a3YOsFtuDDw9=d7_EY60Xvmx4Mc=NJmsy3f3Y9L87Ub=g@mail.gmail.com>
Subject: Re: [PATCH v10 03/14] exfat: add inode operations
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        gregkh <gregkh@linuxfoundation.org>,
        Valdis Kletnieks <valdis.kletnieks@vt.edu>,
        Christoph Hellwig <hch@lst.de>, sj1557.seo@samsung.com,
        linkinjeon@gmail.com,
        =?UTF-8?Q?Pali_Roh=C3=A1r?= <pali.rohar@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon <namjae.jeon@samsung.com> wrote:

> +       /* set FILE_INFO structure using the acquired struct exfat_dentry */
> +       exfat_set_entry_time(sbi, &inode->i_ctime,
> +                       &ep->dentry.file.create_time,
> +                       &ep->dentry.file.create_date,
> +                       &ep->dentry.file.create_tz);
> +       exfat_set_entry_time(sbi, &inode->i_mtime,
> +                       &ep->dentry.file.modify_time,
> +                       &ep->dentry.file.modify_date,
> +                       &ep->dentry.file.modify_tz);
> +       exfat_set_entry_time(sbi, &inode->i_atime,
> +                       &ep->dentry.file.access_time,
> +                       &ep->dentry.file.access_date,
> +                       &ep->dentry.file.access_tz);

I wonder if i_ctime should be handled differently. With statx() we finally have
a concept of "file creation time" in "stx_btime". so it would make sense to
store dentry.file.create_time in there rather than in i_ctime.

It seems that traditionally most file systems that cannot store ctime separately
just set i_ctime and i_mtime both to what is is modify_time here, though
fat and hpfs use i_ctime to refer to creation time.

      Arnd