Subject: Re: [Xen-devel] Re: [PATCH 2.6.12.6-xen] sysfs attributes for xen
From: Dave Hansen <haveblue@us.ibm.com>
To: "Mike D. Day" <ncmike@us.ibm.com>
Cc: Greg KH <greg@kroah.com>, xen-devel@lists.xensource.com,
       lkml <linux-kernel@vger.kernel.org>
In-Reply-To: <43DE45A4.6010808@us.ibm.com>
References: <43DAD4DB.4090708@us.ibm.com>
	 <1138637931.19801.101.camel@localhost.localdomain>
	 <43DE45A4.6010808@us.ibm.com>
Content-Type: text/plain
Date: Mon, 30 Jan 2006 09:04:25 -0800
Message-Id: <1138640666.19801.106.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1146
Lines: 26

On Mon, 2006-01-30 at 11:58 -0500, Mike D. Day wrote:
> Dave Hansen wrote:
> > Where does that 1024 come from?  Is it a guarantee from Xen that it will
> > never fill more than 1k?  I know it is a long shot, but what if the page
> > size is less than 1k?  Would this function have strange results?
> 
> Per the xen headers, this particular hcall option returns a typedef
> char[1024] thingy_t (which is simply a char [1024] in the patch). Yes,
> if the page size is < 1024 there is a problem. So a check against
> PAGE_SIZE may be prudent. 

I was just looking, and noticed that there is a check in the sysfs
->show() code that checks for return values greater than PAGE_SIZE and
BUG()s, so you at least won't get silent corruption.  That is probably
good enough to not worry about it.

In the final version, there will be available Xen headers, and the patch
won't need the open-coded 1024?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/