Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp6460822ybl; Wed, 15 Jan 2020 05:08:39 -0800 (PST) X-Google-Smtp-Source: APXvYqyM9P2IEiSRdryy4f+3arBGKEp4Et06CZZUv8kTUIMRX+gYb3Otgcq0lOVhdhY0U+41bihz X-Received: by 2002:a54:401a:: with SMTP id x26mr20038147oie.101.1579093719194; Wed, 15 Jan 2020 05:08:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579093719; cv=none; d=google.com; s=arc-20160816; b=nrviJpt6yo5Ssl4+k4w2rZNo8ShSeVCu4IMdxmKosA2XUVkOJDKDbgRMTuc7HVw5j4 SQNxn3n8fAoTagiDHBRwz3ITozMe36DHJVxzDL5rOMwWnh9OP3IuJRScjydVmnpncjEp Q4i2KXKZuPx05Z1rSu8XfWqoRbSAd8luITvVRKQVxYTvBN/oJ6f/qC3O2gQ0yZJ5B8Pw bZ7ucc+5lEelTF3MWgpq4tuCD2E/TRtqtexw0cu9o8hf7gvh1/pigGYy+x8HsQR9zUKI dSoUhc02boB+l6dPCF3CrmJhxSEAxTjmS9FENOtOrHMKicN86nOXFJAnTJRwL0AA2cs1 3d1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:references:in-reply-to:mime-version :dkim-signature; bh=H6BEq2s6qwUB7XkhW258dUzmVLj2UZKqUrk3pae1Gs0=; b=pM3I5hnKaxYO2d67pa8aKcq0eLjMeESF+zFQWmC6ThG2ycJy5f/K8Ju+FaMf/PGno7 5RyUP/MnGabEFSZV/Wl6Vdw+o+d/7dsXJfYAxtuz7c9BR37Mi2IV/6L/e8i3Ht5owl0i MIY8StHOFrZ5Ap6PvHmI+bHoFITO4DEQQ0xJRtd3eRzcELGBzfSYAMv0I08+BObD2SU8 H0L96yNiKGIC0IIxbw/d+lCwXgt3VUVWNGciQ+wjg7K8ej3NaMR2SxgBOKjC029OV9B4 QJ7Mfn0Qj3dkPphnFn+FF+JO6GCzuHwN3ctEVFLZ1zYH00BYvMtAdiSp2FFm1MfwHmEY ec2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DA06P+qi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c11si10181874oib.246.2020.01.15.05.08.25; Wed, 15 Jan 2020 05:08:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DA06P+qi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728963AbgAONF5 (ORCPT + 99 others); Wed, 15 Jan 2020 08:05:57 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:40100 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbgAONF5 (ORCPT ); Wed, 15 Jan 2020 08:05:57 -0500 Received: by mail-oi1-f194.google.com with SMTP id c77so15264813oib.7; Wed, 15 Jan 2020 05:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=H6BEq2s6qwUB7XkhW258dUzmVLj2UZKqUrk3pae1Gs0=; b=DA06P+qiBjRI7oO1e/2aTjANs8Bvc8xArp5OO1/uEkYRSL67h0uVkDIX8RuCQ3q6UC yUx3NZGpyUwsjlJR+7lXFQyPQZYbv7+bvq2SqDpso0ARNvGna96AeghU4NEpK7hzlB0v TuBwjCmLxfQBtNw6s/Zukpe2JP692kbTWUg720/XzLDrK/m3Sbhousk0icyggOFPK+jF VM4dacW6MsdAlq6NgK0eQqpMb8n609anzI8svSQszTHWovXnlbVxBPIic5pHyQrKQvKE W519w+qVJH1o7nPGhN8E0OBzC8TbgeC5EUamtbPVz1ViXVeQHBbyXSmZ3s+OaeElUAXE kaZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=H6BEq2s6qwUB7XkhW258dUzmVLj2UZKqUrk3pae1Gs0=; b=m4wLr8UaHyV+gZUf0pDwoHIeY0NcgGaInTQMrCrDLyGyXlkw7V7coZzdqHLOboKdLs IDon4aYa3STvnAwJMxCwUmNKJF6oNGUe6qq/5W8BgtCzc27gD0yC5CnaYkqYYPy0khvg j8504ucoCw/fPkj8mQRnW210mnBMjrYsY3brpPCM0eJY4ac6idNH9lSGvp/pVxcWtcZH MeGhX10HH49GmzOQe5pB1/JxylnNPbNJ+v8+H4Vp3QpSu1fSfi7dllgVwnEB/K2EVhjT G6S+CXjqdRZW/RZzf5fjiIiW5gHQrayl/I61zQ+1wG17dYavpUDDodBwRfhRSPhm2ESg a8Zw== X-Gm-Message-State: APjAAAVViR7V8SYUHrqT3wVsy5HXEixMPoZT/wUI7uGhBb7l7ApObVb1 mgVCt4XiZfEx378YJ0v8VuaRdkhPXHrAPvueMEQZJw== X-Received: by 2002:a54:4715:: with SMTP id k21mr21339030oik.163.1579093556436; Wed, 15 Jan 2020 05:05:56 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a8a:87:0:0:0:0:0 with HTTP; Wed, 15 Jan 2020 05:05:55 -0800 (PST) In-Reply-To: <20200115094732.bou23s3bduxpnr4k@pali> References: <20200115082447.19520-1-namjae.jeon@samsung.com> <20200115094732.bou23s3bduxpnr4k@pali> From: Namjae Jeon Date: Wed, 15 Jan 2020 22:05:55 +0900 Message-ID: Subject: Re: [PATCH v10 00/14] add the latest exfat driver To: =?UTF-8?Q?Pali_Roh=C3=A1r?= Cc: Namjae Jeon , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de, sj1557.seo@samsung.com, arnd@arndb.de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2020-01-15 18:47 GMT+09:00, Pali Roh=C3=A1r : > Hello! I have reviewed all changes in time when v10 has been preparing. > > There is just a small issue with description of EXFAT_DEFAULT_IOCHARSET > option (see email). Otherwise it looks good you can add my Reviewed-by > on whole patch series. > > Reviewed-by: Pali Roh=C3=A1r Thanks for your review and help. I will add your reviewed-by tag on next version. > > Next steps for future: > > * De-duplicate cache code between fat and exfat. Currently fs/exfat > cache code is heavily copy-paste of fs/fat cache code. > > * De-duplicate UTF-16 functions. Currently fs/exfat has e.g. helper > functions for surrogate pairs copy-paste from fs/nls. > > * Unify EXFAT_DEFAULT_IOCHARSET and FAT_DEFAULT_IOCHARSET. Or maybe > unify it with other filesystems too. > > * After applying this patch series, remote staging exfat implementation. Yep, I will check them. > > -- > Pali Roh=C3=A1r > pali.rohar@gmail.com >