Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 15 Jan 2020 16:20:58 +0200
From:   Mike Rapoport <rppt@linux.ibm.com>
To:     Chen Zhou <chenzhou10@huawei.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        akpm@linux-foundation.org, sfr@canb.auug.org.au,
        keescook@chromium.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next] init/main.c: make some symbols static
References: <20200115135458.71460-1-chenzhou10@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200115135458.71460-1-chenzhou10@huawei.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Message-Id: <20200115142057.GE19826@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

(added Steven and Masami)

On Wed, Jan 15, 2020 at 09:54:58PM +0800, Chen Zhou wrote:
> Make variable xbc_namebuf and function boot_config_checksum static to
> fix build warnings, warnings are as follows:
> 
> init/main.c:254:6:
> 	warning: symbol 'xbc_namebuf' was not declared. Should it be static?
> init/main.c:330:5:
> 	warning: symbol 'boot_config_checksum' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
>  init/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index a77114f..3a95591 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -251,7 +251,7 @@ early_param("loglevel", loglevel);
>  
>  #ifdef CONFIG_BOOT_CONFIG
>  
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>  
>  #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>  
> @@ -327,7 +327,7 @@ static char * __init xbc_make_cmdline(const char *key)
>  	return new_cmdline;
>  }
>  
> -u32 boot_config_checksum(unsigned char *p, u32 size)
> +static u32 boot_config_checksum(unsigned char *p, u32 size)
>  {
>  	u32 ret = 0;
>  
> -- 
> 2.7.4
> 

-- 
Sincerely yours,
Mike.